Upgrade CARTS to Node 18 #139609
Merged
Upgrade CARTS to Node 18 #139609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmrabian
commented
Apr 16, 2024
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
gmrabian
commented
Apr 16, 2024
|
Code Climate has analyzed commit 3b51e71 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (90% is the threshold). This pull request will bring the total coverage in the repository to 79.3% (0.0% change). View more on Code Climate. |
gmrabian
commented
Apr 16, 2024
gmrabian
requested review from
berryd,
keeysnc,
britt-mo,
dwhitestratiform,
karla-vm and
benmartin-coforma
berryd
approved these changes
Apr 16, 2024
BearHanded
approved these changes
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deployed url: https://d1jelkmfipicog.cloudfront.net/
Description
Upgrade project-wide node version to 18.17.0 (or closest). Biggest places are:
.nvmrcwhich determines what version developers use locally (and most CI actions)*/serverless.ymlwhich determines what version any deployed instances use (mainly (exclusively?) lambda versions)Let me know if I've missed any places! I searched for
16.,14.,16, andnode.Related ticket(s)
CMDCT-3455
How to test
Everything works as expected
Notes
Pre-review checklist
Screenshots
All lambdas running on node18 in AWS (except one that is created by serverless to run a task it thinks it might not be able to run in cloudformation 🤔 )
