CMDCT-4184 cdk-side prepping cdk to import Cloudfront Distribution #14991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peoplespete
force-pushed
the
cmdct-4184-cdk
branch
from
c289ddd to
bcd5ba1
Compare
peoplespete
force-pushed
the
cmdct-4184-cdk
branch
from
bcd5ba1 to
3935ac4
Compare
peoplespete
commented
Dec 10, 2024
| @@ -136,7 +148,6 @@ export function createUiComponents(props: CreateUiComponentsProps) { | |||
| const applicationEndpointUrl = `https://${distribution.distributionDomainName}/`; | |||
|
|
|||
| setupWaf(scope, stage, project, deploymentConfigParameters); | |||
| setupRoute53(scope, distribution, deploymentConfigParameters); | |||
There was a problem hiding this comment.
This was never actually being created or used.
peoplespete
commented
Dec 10, 2024
deployment/stacks/ui.ts
Outdated
| @@ -95,6 +93,20 @@ export function createUiComponents(props: CreateUiComponentsProps) { | |||
| } | |||
| ); | |||
|
|
|||
| // new cloudfront.Distribution( | |||
There was a problem hiding this comment.
This is the simplified version of the distribution that will initially be used for import. Once imported we'll update it to bring it back into the fully featured setup Jon got working for cdk.
peoplespete
requested review from
BearHanded,
braxex,
jessabean and
benmartin-coforma
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change is not to be deployed until we are ready to convert to cdk. For full details of the order of events recommended to preserve our Cloudfront Distribution check out this readme: https://github.com/Enterprise-CMCS/macpro-mdct-seds/blob/cmdct-4184-cdk/import_instructions.md
The idea is that by preserving Cloudfront Distribution we will be able to deploy cdk without requiring any external DNS changes. 🎉
Related ticket
CMDCT-4184
How to test
If you want to you can do the following to test this PR:
Notes
NA
Pre-review checklist
Pre-merge checklist
Review
Security
If either of the following are true, notify the team's ISSO (Information System Security Officer).
convert to a different template: test → val | val → prod