Skip to content

Commit

Permalink
Update terminology from "subsequent submission" to "subsequent docume…
Browse files Browse the repository at this point in the history
…nts" (#1514)

changed subsub to subdoc across app
  • Loading branch information
andieswift authored Oct 3, 2024
1 parent 6c59184 commit af51671
Show file tree
Hide file tree
Showing 29 changed files with 30 additions and 30 deletions.
2 changes: 1 addition & 1 deletion services/app-api/email/CMSSubsequentSubmissionNotice.js
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ export const CMSSubsequentSubmissionNotice = async (data, config) => {
let typeLabel = config.typeLabel;
// cut the type label at sub sub and set that at the new idLabel
typeLabel = typeLabel
.substring(0, typeLabel.indexOf("Subsequent Submission"))
.substring(0, typeLabel.indexOf("Subsequent Documents"))
.trim();
config.idLabel = `${typeLabel} Package ID`;
}
Expand Down
2 changes: 1 addition & 1 deletion services/app-api/email/stateSubsequentSubmissionReceipt.js
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ export const stateSubsequentSubmissionReceipt = (data, config) => {
let typeLabel = config.typeLabel;
// cut the type label at sub sub and set that at the new idLabel
typeLabel = typeLabel
.substring(0, typeLabel.indexOf("Subsequent Submission"))
.substring(0, typeLabel.indexOf("Subsequent Documents"))
.trim();
config.idLabel = `${typeLabel} Package ID`;
}
Expand Down
2 changes: 1 addition & 1 deletion services/common/type/initialWaiverSubsequentSubmission.js
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import { ONEMAC_TYPE } from "../workflow.js";
export const initialWaiverSubsequentSubmission = {
...initialWaiver,
componentType: ONEMAC_TYPE.WAIVER_INITIAL_SUBSEQUENT_SUBMISSION,
typeLabel: "1915(b) Initial Waiver Subsequent Submission",
typeLabel: "1915(b) Initial Waiver Subsequent Documents",
idMustExist: true,
allowMultiplesWithSameId: true,
requiredAttachments: [], //default to empty and let subtype B or B4 override
Expand Down
2 changes: 1 addition & 1 deletion services/common/type/medicaidSPASubsequentSubmission.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import { medicaidSPA } from "./medicaidSPA.js";
export const medicaidSPASubsequentSubmission = {
...medicaidSPA,
componentType: "medicaidspasubsequent",
typeLabel: "Medicaid SPA Subsequent Submission",
typeLabel: "Medicaid SPA Subsequent Documents",
idMustExist: true,
allowMultiplesWithSameId: true,
requiredAttachments: [],
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import { ONEMAC_TYPE } from "../workflow.js";
export const waiverAmendmentSubsequentSubmission = {
...waiverAmendment,
componentType: ONEMAC_TYPE.WAIVER_AMENDMENT_SUBSEQUENT_SUBMISSION,
typeLabel: "Waiver Amendment Subsequent Submission",
typeLabel: "Waiver Amendment Subsequent Documents",
idMustExist: true,
allowMultiplesWithSameId: true,
allowedParentStatuses: ["Under Review"],
Expand Down
2 changes: 1 addition & 1 deletion services/common/type/waiverAppKSubsequentSubmission.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import { ONEMAC_TYPE } from "../workflow.js";
export const waiverAppKSubsequentSubmission = {
...waiverAppendixK,
componentType: ONEMAC_TYPE.WAIVER_APP_K_SUBSEQUENT_SUBMISSION,
typeLabel: "Waiver Appendix K Subsequent Submission",
typeLabel: "Waiver Appendix K Subsequent Documents",
idMustExist: true,
allowMultiplesWithSameId: true,
requiredAttachments: [],
Expand Down
2 changes: 1 addition & 1 deletion services/common/type/waiverRenewalSubsequentSubmission.js
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ export const waiverRenewalSubsequentSubmission = {
...waiverRenewal,
...waiverRenewalB4,
componentType: ONEMAC_TYPE.WAIVER_RENEWAL_SUBSEQUENT_SUBMISSION,
typeLabel: "Waiver Renewal Subsequent Submission",
typeLabel: "Waiver Renewal Subsequent Documents",
idMustExist: true,
allowMultiplesWithSameId: true,
allowedParentTypes: ["waiverrenewal"],
Expand Down
2 changes: 1 addition & 1 deletion services/ui-src/src/libs/formLib.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ export const defaultOneMACFormConfig = {

export const defaultSubsequentSubmissionFormConfig = {
...defaultOneMACFormConfig,
addlInfoTitle: "Reason for subsequent submission",
addlInfoTitle: "Reason for subsequent documents",
addlInfoText: "Explain why additional documents are being submitted.",
};

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jest.mock("../../utils/PackageApi");
window.HTMLElement.prototype.scrollIntoView = jest.fn();
window.scrollTo = jest.fn();

describe("Chip SPA Subsequent Submission Form", () => {
describe("Chip SPA Subsequent Documents Form", () => {
let history;

beforeEach(() => {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ export const chipSPASubsequentSubmissionFormInfo: OneMACFormConfig = {
...defaultSubsequentSubmissionFormConfig,
...chipSPASubsequentSubmission,
pageTitle: "Upload Subsequent CHIP SPA Documentation",
detailsHeader: "CHIP SPA Subsequent Submission",
detailsHeader: "CHIP SPA Subsequent Documents",
landingPage: ONEMAC_ROUTES.PACKAGE_LIST_SPA,
confirmSubmit: defaultConfirmSubsequentSubmission,
validateParentAPI: "validateParentOfAny",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ jest.mock("../../utils/PackageApi");
window.HTMLElement.prototype.scrollIntoView = jest.fn();
window.scrollTo = jest.fn();

describe("1915(b) Initial Waiver Subsequent Submission Form", () => {
describe("1915(b) Initial Waiver Subsequent Documents Form", () => {
let history;

beforeEach(() => {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ export const initialWaiverSubsequentSubmissionFormInfo: OneMACFormConfig = {
...defaultSubsequentSubmissionFormConfig,
...initialWaiverSubsequentSubmission,
pageTitle: "Upload Subsequent Waiver Documentation",
detailsHeader: "Initial Waiver Subsequent Submission",
detailsHeader: "Initial Waiver Subsequent Documents",
landingPage: ONEMAC_ROUTES.PACKAGE_LIST_WAIVER,
confirmSubmit: defaultConfirmSubsequentSubmission,
validateParentAPI: "validateParentOfAny",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jest.mock("../../utils/PackageApi");
window.HTMLElement.prototype.scrollIntoView = jest.fn();
window.scrollTo = jest.fn();

describe("Medicaid SPA Subsequent Submission Form", () => {
describe("Medicaid SPA Subsequent Documents Form", () => {
let history;

beforeEach(() => {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ export const medicaidSPASubsequentSubmissionFormInfo: OneMACFormConfig = {
...defaultSubsequentSubmissionFormConfig,
...medicaidSPASubsequentSubmission,
pageTitle: "Upload Subsequent Medicaid SPA Documentation",
detailsHeader: "Medicaid SPA Subsequent Submission",
detailsHeader: "Medicaid SPA Subsequent Documents",
landingPage: ONEMAC_ROUTES.PACKAGE_LIST_SPA,
confirmSubmit: defaultConfirmSubsequentSubmission,
validateParentAPI: "validateParentOfAny",
Expand Down
2 changes: 1 addition & 1 deletion services/ui-src/src/page/section/AdditionalInfoSection.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ export const AdditionalInfoSection: FC<{
<section id={id} className="detail-section">
<h2>
{isSubSub
? "Reason for subsequent submission"
? "Reason for subsequent documents"
: "Additional Information"}
</h2>
<Review
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ jest.mock("../../utils/PackageApi");
window.HTMLElement.prototype.scrollIntoView = jest.fn();
window.scrollTo = jest.fn();

describe("1915(b) Waiver Amendment Subsequent Submission Form", () => {
describe("1915(b) Waiver Amendment Subsequent Documents Form", () => {
let history;

beforeEach(() => {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ export const waiverAmendmentSubsequentSubmissionFormInfo: OneMACFormConfig = {
...defaultSubsequentSubmissionFormConfig,
...waiverAmendmentSubsequentSubmission,
pageTitle: "Upload Subsequent Waiver Amendment Documentation",
detailsHeader: "Waiver Amendment Subsequent Submission",
detailsHeader: "Waiver Amendment Subsequent Documents",
landingPage: ONEMAC_ROUTES.PACKAGE_LIST_WAIVER,
confirmSubmit: defaultConfirmSubsequentSubmission,
validateParentAPI: "validateParentOfWaiverAmendment",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jest.mock("../../utils/PackageApi");
window.HTMLElement.prototype.scrollIntoView = jest.fn();
window.scrollTo = jest.fn();

describe("1915(c) Waiver Appendix K Subsequent Submission Form", () => {
describe("1915(c) Waiver Appendix K Subsequent Documents Form", () => {
let history;

beforeEach(() => {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ export const waiverAppKSubsequentSubmissionFormInfo: OneMACFormConfig = {
...defaultSubsequentSubmissionFormConfig,
...waiverAppKSubsequentSubmission,
pageTitle: "Upload Subsequent 1915(c) Appendix K Documentation",
detailsHeader: "1915(c) Appendix K Subsequent Submission",
detailsHeader: "1915(c) Appendix K Subsequent Documents",
landingPage: ONEMAC_ROUTES.PACKAGE_LIST_WAIVER,
confirmSubmit: defaultConfirmSubsequentSubmission,
validateParentAPI: "validateParentOfAny",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ jest.mock("../../utils/PackageApi");
window.HTMLElement.prototype.scrollIntoView = jest.fn();
window.scrollTo = jest.fn();

describe("1915(b) Waiver Renewal Subsequent Submission Form", () => {
describe("1915(b) Waiver Renewal Subsequent Documents Form", () => {
let history;

beforeEach(() => {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ export const waiverRenewalSubsequentSubmissionFormInfo: OneMACFormConfig = {
...defaultSubsequentSubmissionFormConfig,
...waiverRenewalSubsequentSubmission,
pageTitle: "Upload Subsequent Waiver Renewal Documentation",
detailsHeader: "Waiver Renewal Subsequent Submission",
detailsHeader: "Waiver Renewal Subsequent Documents",
landingPage: ONEMAC_ROUTES.PACKAGE_LIST_WAIVER,
confirmSubmit: defaultConfirmSubsequentSubmission,
validateParentAPI: "validateParentOfWaiverRenewal",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ Feature: Subsequent Submission 1915b Waiver Amendment
Then click Under Review checkbox
Then Click on Filter Button

Scenario: Screen Enhance - Subsequent Document from the details page
Scenario: Screen Enhance - Subsequent Documents from the details page
Then click the Waiver Number link in the first row
Then verify the package details page is visible
Then verify Upload Subsequent Documents action exists
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ Feature: Subsequent Submission 1915c App K Waiver
Then click Under Review checkbox
Then Click on Filter Button

Scenario: Screen Enhance - Subsequent Document from the details page
Scenario: Screen Enhance - Subsequent Documents from the details page
Then click the Waiver Number link in the first row
Then verify the package details page is visible
Then verify Upload Subsequent Documents action exists
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ Feature: CHIP SPA State Details View - Card View with Actions
Then click Under Review checkbox
Then Click on Filter Button

Scenario: Screen Enhance - Subsequent Document from the details page
Scenario: Screen Enhance - Subsequent Documents from the details page
Then click the SPA ID link in the first row
Then verify the package details page is visible
Then verify Upload Subsequent Documents action exists
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ Feature: Subsequent Submission 1915b Initial Waiver
Then click Under Review checkbox
Then Click on Filter Button

Scenario: Screen Enhance - Subsequent Document from the details page
Scenario: Screen Enhance - Subsequent Documents from the details page
Then click the Waiver Number link in the first row
Then verify the package details page is visible
Then verify Upload Subsequent Documents action exists
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ Feature: Medicaid SPA State Details View - Card View with Actions
Then click Under Review checkbox
Then Click on Filter Button

Scenario: Screen Enhance - Subsequent Document from the details page
Scenario: Screen Enhance - Subsequent Documents from the details page
Then click the SPA ID link in the first row
Then verify the package details page is visible
Then verify Upload Subsequent Documents action exists
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ Feature: Subsequent Submission 1915b Renewal Waiver
Then click Under Review checkbox
Then Click on Filter Button

Scenario: Screen Enhance - Subsequent Document from the details page
Scenario: Screen Enhance - Subsequent Documents from the details page
Then click the Waiver Number link in the first row
Then verify the package details page is visible
Then verify Upload Subsequent Documents action exists
Expand Down
2 changes: 1 addition & 1 deletion tests/cypress/cypress/e2e/common/steps.js
Original file line number Diff line number Diff line change
Expand Up @@ -2086,7 +2086,7 @@ Then("click the Upload Subsequent Documents action button", () => {
Then("verify the Subsequent {string} Documents section exists", (type) => {
OneMacFormPage.verifySubsequentDocumentsSectionExistsWith(type);
});
Then("verify the Reason for subsequent submission section exists", () => {
Then("verify the Reason for subsequent documents section exists", () => {
OneMacFormPage.verifyAdditionalInfoSectionExists();
});
Then("verify the dialog title contains {string}", (s) => {
Expand Down
4 changes: 2 additions & 2 deletions tests/cypress/support/pages/oneMacFormPage.js
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ const subsequentDocumentsHeader = (type) =>
`//h3[contains(text(),'Subsequent ${type} Documents')]`;
const labelElementFromLabel = {
"Additional Information": "#additional-information-label",
"Reason for subsequent submission": "#additional-information-label",
"Reason for subsequent documents": "#additional-information-label",
};
const elementFromLabel = {
// Different forms may have different labels for the ID field
Expand All @@ -41,7 +41,7 @@ const elementFromLabel = {
"Existing Waiver Number to Renew": parentIdElement,
"Existing Waiver Number to Amend": parentIdElement,
"Additional Information": "#additional-information",
"Reason for subsequent submission": "#additional-information",
"Reason for subsequent documents": "#additional-information",
};
const errorMessageLine1FromLabel = {
"SPA ID": "#componentIdStatusMsg0",
Expand Down

0 comments on commit af51671

Please sign in to comment.