Changes required for Mako (#1365) #1370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add a source service to stream onemac data to kafka (#1292) * Add a source service to stream data out of dynamo * set the deploy to be conditional and honor the correct envs * Add a cross account role to fetch S3 uploads (#1319) * feat(cross-acct service): Create a cross acct role for uploads * correct names * deps * Add getobjecttagging perms so we can honor the clean tags
Dark-Knight-1313
requested review from
kristin-at-theta,
bflynn-cms and
hannasage
as code owners
kristin-at-theta
approved these changes
Sep 21, 2023
mdial89f
approved these changes
Sep 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a source service to stream onemac data to kafka (Add a source service to stream onemac data to kafka #1292)
Add a source service to stream data out of dynamo
set the deploy to be conditional and honor the correct envs
Add a cross account role to fetch S3 uploads (Add a cross account role to fetch S3 uploads #1319)
feat(cross-acct service): Create a cross acct role for uploads
correct names
deps
Add getobjecttagging perms so we can honor the clean tags
Story: https://qmacbis.atlassian.net/browse/OY2-XXXX
Endpoint: See github-actions bot comment
Details
A quick summary of the intended outcome of this PR.
Changes
Implementation Notes
Test Plan