Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PI1 25619: Update Node Js 10.x to 12.x versions to latest compatible versions (ie 18.x / 19.x) #1371

Merged
merged 10 commits into from
Sep 26, 2023

Conversation

kristin-at-theta
Copy link
Collaborator

Story: https://qmacbis.atlassian.net/browse/OY2-25619
Endpoint: See github-actions bot comment

Details

Update/upgrade action packages to remove node warnings

Changes

  • updated actions/checkout from v1 to v3
  • updated actions/setup-node from v1 to v3
  • updated actions/cache from v2 to v3
  • updated aws-actions/configure-aws-credentials from v1 to v4
  • updated paambaati/codeclimate-action from v2.7.5 to v5.0.0
  • updated node versions to 18
  • added the --legacy-peer-deps flag to the npm ci builds so the legacy dependencies don't fail the deployment

Test Plan

  1. Repository should deploy
  2. No new test issues
  3. Application should run as before

@github-actions
Copy link

Endpoint URL - https://d3nabnwh9k2qdh.cloudfront.net

@kristin-at-theta kristin-at-theta marked this pull request as ready for review September 25, 2023 21:25
Copy link
Collaborator

@bflynn-cms bflynn-cms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good as far as I can tell!
Was suspicious about the failed cypress tests but in each case it seems to be a cypress/data error. When doing a self smoke test on the app everything seemed fine.

I know you mentioned fixing unit tests but as that will not impact application behavior I am marking as...Approved!

@kristin-at-theta kristin-at-theta merged commit 191542f into develop Sep 26, 2023
@kristin-at-theta kristin-at-theta deleted the pi1-25619-lc branch September 26, 2023 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants