Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PI1.4 26079: FAQ Search expansion #1403

Merged
merged 4 commits into from
Nov 8, 2023
Merged

PI1.4 26079: FAQ Search expansion #1403

merged 4 commits into from
Nov 8, 2023

Conversation

kristin-at-theta
Copy link
Collaborator

Story: https://qmacbis.atlassian.net/browse/OY2-26079
Endpoint: See github-actions bot comment

Details

Add an "Expand all" button to the FAQ page to allow Ctrl-F to search all FAQ text.

Changes

  • moved the FAQ content into the React state to get native rendering
  • added isOpen to the faqcontent items in json
  • switched the Accordian component from default to Controlled open to allow the application to open and close the questions
  • added the handler for opening and closing
  • added a button at the top of the page that opens all the questions

Implementation Notes

To do this properly, would really be best to remove the hashHandler and use the state to manage which item shows, etc. Also, there is probably value in dividing the components even further, so a change to one QandA doesn't have to alter the entire faq content state to render. HOWEVER, this was only a 2 point story and it does not look like our work on the FAQ page is going to be migrated.

Also note... using the Expand button does NOT automatically re-trigger the Ctrl-F search in the browser - you have to edit the text to be searched in some way.

Test Plan

  1. Open the application
  2. Click the FAQ link
  3. Click the "Expand all to search with CTRL+F" button
  4. Verify the all sections expand
  5. Verify text is searchable
  6. Verify other application FAQ links work as before (expanding and moving to correct places)

Copy link

github-actions bot commented Nov 3, 2023

Endpoint URL - https://d2cbxuqpis7kl1.cloudfront.net

@kristin-at-theta kristin-at-theta marked this pull request as ready for review November 3, 2023 19:08
Copy link
Collaborator

@bflynn-cms bflynn-cms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks and functions well!

Approved

@kristin-at-theta kristin-at-theta merged commit c5ef635 into develop Nov 8, 2023
90 of 92 checks passed
@kristin-at-theta kristin-at-theta deleted the pi1-26079 branch November 8, 2023 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants