Sprint 79 and observability epic merge #1406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Valencia McMurray <[email protected]>
* Fix wrap on status col * minor changes * Change method of display * Update memo deps
* feat(cross-acct service): Create a cross acct role for uploads * correct names * deps * Add getobjecttagging perms so we can honor the clean tags
* Refactor triage cards * Refator State Access cards * Additional jsdoc comments * Save point: FileList handled, status and action boxes in progress * Oops, remove that unused import * Update prop name * Simplify home page content; use maccard on home page * Triage styling refactor * Remove ChoiceItem files * Linter fix * Fix home page content styling issues * h1 style fix for home page content * Fix signup breaking changes * Fixing userpage test * maccard border adjustments * Updates to fieldset and options * Undo signup changes due to scope * Detail cards * Remove unused import * Refactor signup and remove choicelist * Refactor faq display and contact card * Fix lint error * Fix the broken faq test * Remove commented code in test * Add tests * Lint fixes * Minor fixes * Linter needs to shut up about this component and just be grateful that I'm even refactoring this stuff * Remove CMS onClick signup for new pattern * Remove prop control for gradient bar * Remove completed to-do * Minor types change * element reference fixes - these tag updates should fix the majority of the test issues. - also updated the version of actions/checkout * Add log task reference for testing - seems like some accessibility automation tests failed due to accessibility issues that they couldn't log because the task didn't exist. This change implements the log task. - also I noticed some accessibility tests were duplicates so I removed those two. * Fix CMS role request for Role Approver * Update deprecation comments * Fix lint error * Fix lint error * Fix a11y duplicate-id * Fix a11y heading-order * Fix broken styles in access view * Fix HomePage.spec.feature test update element xpaths --------- Co-authored-by: Valencia McMurray <[email protected]>
* Normalize chosen dates to beginning and end of day * Fixes null length error
* Shorten given list of extensions * Fix wording
Bumps [@adobe/css-tools](https://github.com/adobe/css-tools) from 4.2.0 to 4.3.1. - [Changelog](https://github.com/adobe/css-tools/blob/main/History.md) - [Commits](https://github.com/adobe/css-tools/commits) --- updated-dependencies: - dependency-name: "@adobe/css-tools" dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [tough-cookie](https://github.com/salesforce/tough-cookie) and [@cypress/request](https://github.com/cypress-io/request). These dependencies needed to be updated together. Updates `tough-cookie` from 2.5.0 to 4.1.3 - [Release notes](https://github.com/salesforce/tough-cookie/releases) - [Changelog](https://github.com/salesforce/tough-cookie/blob/master/CHANGELOG.md) - [Commits](salesforce/tough-cookie@v2.5.0...v4.1.3) Updates `@cypress/request` from 2.88.11 to 2.88.12 - [Release notes](https://github.com/cypress-io/request/releases) - [Changelog](https://github.com/cypress-io/request/blob/master/CHANGELOG.md) - [Commits](cypress-io/request@v2.88.11...v2.88.12) --- updated-dependencies: - dependency-name: tough-cookie dependency-type: indirect - dependency-name: "@cypress/request" dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Kristin Grue <[email protected]>
Co-authored-by: Valencia McMurray <[email protected]>
…status (#1362) * allow package withdraw for withdraw rai response enabled status * update test coverage * update tests to include withdraw action check --------- Co-authored-by: Valencia McMurray <[email protected]>
…ray diffing (#1364) * Extract filter chip tray and create context * Refactor to simplify context * Plug in filter chip dispatch for subtractive filter UIs * Filters update context state * Save Point: All functionality but chip removal logic done * Fix filter removal logic on chip close button * Chip removal functionally removes filter * Save Point: Figuring out loading from saved filter state * Saved filter chip state works * Fix lint errors * better locators for tests some duplicate references are causing tests to fail. Pass at fixing those. - also saw some unused steps so I removed some of those. --------- Co-authored-by: Valencia McMurray <[email protected]>
* Update additional info text * test update realized I was missing a few closing brackets on locators which is causing some of the failures in the tests. * test dupe fix duplicate verifyCPOCNameDoesNotExists. --------- Co-authored-by: Valencia McMurray <[email protected]>
* Add filter count to filter button * Fix date filter bug
…versions (ie 18.x / 19.x) (#1371)
* initialize e2e test suite I got the Basic Smoke Test File to run. I didn't get it setup in the pipeline because I believe that is a different story. * put code in function pageHasLoaded was empty.
* PI01.02 25326: Add Success Alert for Enable and Disable Withdraw Formal RAI Response Actions (#1375)
* Oy2 25583 - remove duplicate tests from lines 43-1075 (#1378) * removed unused steps from lines 43-1075 * removed functions that are no longer used from page definitions after removing steps * PI1.2-25583: lines 2109-3143 - Kristin (#1377) * commented out unused tests * deleted commented out sections * removed commented out tests, steps, and functions --------- * Retire outdated test cases pt 2 (#1380) lines 1076-2108 in steps were assigned to me. * error fixes and resolving merging weirdness --------- Co-authored-by: bflynn-cms <[email protected]> Co-authored-by: Kristin Grue <[email protected]>
and renaming steps that appeared to be duplicates, but were actually different test steps. Co-authored-by: bflynn-cms <[email protected]>
Co-authored-by: Valencia McMurray <[email protected]>
Co-authored-by: Valencia McMurray <[email protected]>
Co-authored-by: Valencia McMurray <[email protected]>
Dark-Knight-1313
requested review from
kristin-at-theta,
bflynn-cms and
hannasage
as code owners
…us (#1402) * testing using existing status as substatus * dont set new status for withdraw enable; allow action based on substatus * add substatus to package list and force Pending status for rai withdraw enabled * rework how eventTimestamp factors into package builder * fix tests * oy2-24635 - keep latest rai response date upon enable withdraw * dont allow enable action if already enabled (since enabled is no longer its own package status) * enable withdraw was setting rai date as action date instead of current date * updating RAI Withdraw Enable related tests * merge develop * use parent section for sub status test step * Update oneMacPackageDetailsPage.js * add id to subsections * simplified tests with IDs * fix state user tests - missing sub status test step updates in some tests. * fix seed data * verify what happens to MD-23-7650-VM - commented out tests to see the status of MD-23-7650-VM package without it. * regenerate package-lock for tests/full-e2e * try again after also deleting local node_modules and rebuilding package-lock --------- Co-authored-by: Valencia McMurray <[email protected]> Co-authored-by: Valencia McMurray <[email protected]>
Co-authored-by: Valencia McMurray <[email protected]>
Tests: automated tests got reverted by VAL hot fix... fix them
kristin-at-theta
requested changes
Nov 28, 2023
kristin-at-theta
approved these changes
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Story: https://qmacbis.atlassian.net/browse/OY2-XXXX
Endpoint: See github-actions bot comment
Details
This merge is to include work from sprint 79, withdraw RAI and the observability/testing epic
Changes
Implementation Notes
Test Plan