-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
uat merge to masterclone #1502
Merged
Merged
uat merge to masterclone #1502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* OY2 23552: Latest Package Activity - Package Details Page + Dashboard (#1353) Co-authored-by: Valencia McMurray <[email protected]> * Oy2 23798 - Subsequent Submissions (#1342) * add subsequent submission action (form not yet implemented) * fix error in action delegate and corresponding tests * add new forms and config for subsequent submission * not sure where that came from??? * Add custom success banner * placeholder in one stream to build parent so that submit can release lock * fix Cover Letter filter and attachment link for medicaid * fix navigational back button on form Let back nav button return you to details page if that is where you came from or to proper tab in package list if that is where you came from * fix attachment language text per figma - despite nothing in the ACs ;) * tests to cover subsequent submissions * consolidate more of the Config * Update submitWaiverAmendmentSubsequentSubmission.js * tune required markings * test updates had the wrong message in the success banner but realized I maybe shouldn't automate the actual submission without some extra seed data (and holding off on that until reverse chrono seed data is pushed up). * OY2 24868: Update NOSOs Admin Package Change Log Language (#1352) * move secondClockStatuses to common configs (#1346) * Bump @adobe/css-tools from 4.2.0 to 4.3.1 in /services/ui-src (#1355) Bumps [@adobe/css-tools](https://github.com/adobe/css-tools) from 4.2.0 to 4.3.1. - [Changelog](https://github.com/adobe/css-tools/blob/main/History.md) - [Commits](https://github.com/adobe/css-tools/commits) --- updated-dependencies: - dependency-name: "@adobe/css-tools" dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * keep current status after subsequent submission * Bump tough-cookie and @cypress/request (#1332) Bumps [tough-cookie](https://github.com/salesforce/tough-cookie) and [@cypress/request](https://github.com/cypress-io/request). These dependencies needed to be updated together. Updates `tough-cookie` from 2.5.0 to 4.1.3 - [Release notes](https://github.com/salesforce/tough-cookie/releases) - [Changelog](https://github.com/salesforce/tough-cookie/blob/master/CHANGELOG.md) - [Commits](salesforce/tough-cookie@v2.5.0...v4.1.3) Updates `@cypress/request` from 2.88.11 to 2.88.12 - [Release notes](https://github.com/cypress-io/request/releases) - [Changelog](https://github.com/cypress-io/request/blob/master/CHANGELOG.md) - [Commits](cypress-io/request@v2.88.11...v2.88.12) --- updated-dependencies: - dependency-name: tough-cookie dependency-type: indirect - dependency-name: "@cypress/request" dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Kristin Grue <[email protected]> * fix and update subsub tests * final test update some pending packages have actions because of the enable withdraw (unrelated to this work) story. Updated those. The tests failing because they can't find a package will be left and those are fixed elsewhere. * OY2 24628: OneMAC Package Details - Reverse Chronological order (#1338) Co-authored-by: Valencia McMurray <[email protected]> * some of the tests --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Valencia McMurray <[email protected]> Co-authored-by: Kristin Grue <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Valencia McMurray <[email protected]> * merge develop to sub-sub * OY2-25114 - subsequent submission reverse chrono (#1372) * initial implementation of subsequent submission chronological order * Update actionDelegate.test.js * test Subsequent Documentation in reverse chrono --------- Co-authored-by: Valencia McMurray <[email protected]> * Oy2 23799 - add emails for subsequent submissions (#1368) * add emails for subsequent submissions * lint * rebuild package lock just to force a build * Update package-lock.json * fix lint * test refactor * add subsequent submission maps * test updates: latest activity re-adding latest activity and updating some attachment steps to match current dev. * Mege latest develop (#1479) * Update serverless.yml changed x-content-type-options to lowercase to see if the value will change * Update api-gateway.yml Another addition to set the x-Content-Type-Options to nosniff * Update api-gateway.yml Fix error where code was placed * Add aws-sdk, esbuild, and configuration to fix the legacy source to kafka * set default timeout to 2.5minutes for all api lambda (#1475) * continue pipeline even if issues with seed data (#1478) --------- Co-authored-by: Dark-Knight-1313 <[email protected]> Co-authored-by: Mike Dial <[email protected]> * add changes for Oy2 28890 to sub sub (#1480) * Update serverless.yml changed x-content-type-options to lowercase to see if the value will change * Update api-gateway.yml Another addition to set the x-Content-Type-Options to nosniff * Update api-gateway.yml Fix error where code was placed * ignore email records for package builder --------- Co-authored-by: Dark-Knight-1313 <[email protected]> * OY2-28810 - keep substatus after subsequent submission * Update buildAnyPackage.js * oy2-28987 - update email notification text to state for sub sub (#1484) updated email notification text to state for subsequent submissions * oy2-28988: sub sub CMS email fix (#1491) updated text in email notification for cms for subsequent submissions * added same text change from the other broken branch (#1488) * oy2-28672 - update sub sub confirmation popup text (#1486) * oy2-28671 - update subsequent submission additional information text (#1482) * update subsequent submission additional information text * added conditional text on the package details page for sub subs --------- Co-authored-by: Andie Swift <[email protected]> * update build package to add latest activity timestamp * remove submissionTimestamp from subsequent submission config * Merge branch 'subsub2' into develop --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Kristin Grue <[email protected]> Co-authored-by: Valencia McMurray <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Valencia McMurray <[email protected]> Co-authored-by: Dark-Knight-1313 <[email protected]> Co-authored-by: Mike Dial <[email protected]> Co-authored-by: Andie Swift <[email protected]> Co-authored-by: Andie Swift <[email protected]>
Dark-Knight-1313
requested review from
kristin-at-theta and
bflynn-cms
as code owners
August 30, 2024 15:35
* textarea selectors mixed up details page and form submission page selectors. Fixed and updated sub sub ones. * fixed capitalization on method * step and test alterations * updates - removed Dashboard RAI WIthdraw Enabled Actions test because the checkbox is no longer relevant (status was changed to "sub status" and that does not have a checkbox). - fix capitalization in label string for sub sub * latest package activity - Dashboard_Filter_options_that_include_Dates_CMS.spec.feature fix - added latest package activity test to State filter options spec as well * seed data fix - removed reference to deprecated test spec in deploy - fixed seed data entry that was missing an initial package entry. Might also fix the lack of attachments on this when attempting a sub sub!
bflynn-cms
approved these changes
Aug 30, 2024
andieswift
approved these changes
Aug 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am seeing the email changes and subsub functionality on the URL so I am good with this 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Story: https://qmacbis.atlassian.net/browse/OY2-XXXX
Endpoint: See github-actions bot comment
Details
The purpose of this PR is to create an environment for sub-sub UAT with locking down the validation by merging inta a clone of the branch.
Changes
Implementation Notes
Test Plan