Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Notification Card & Banner #1504

Merged
merged 1 commit into from
Sep 20, 2024
Merged

UI: Notification Card & Banner #1504

merged 1 commit into from
Sep 20, 2024

Conversation

andieswift
Copy link
Collaborator

@andieswift andieswift commented Sep 13, 2024

Sub task of Story: https://qmacbis.atlassian.net/browse/OY2-20181
Endpoint: See github-actions bot comment

Mock up

Mock up can be viewed in this Story: https://qmacbis.atlassian.net/browse/OY2-29947

Changes

  • Created new component NotificationBanner
  • Added Card component in with other MAC Cards

Implementation Notes

  • Have not added context yet
  • Created new component for Notification Banner rather than using the Alert because the logic needed in the component is quite different
  • The new card component is in it's own file as well under NotificationCard

Screenshots

Right now, you won't see these on the home screen. I just put it there for testing purposes and removed it on my last commit.

Notification Banner
Screenshot 2024-09-17 at 3 08 23 PM

Notification Card
Screenshot 2024-09-17 at 11 21 39 AM

Copy link

Endpoint URL - Environment not yet deployed, delete this comment and run the Pull Request workflow again after deploy is complete

@andieswift andieswift changed the base branch from develop to bf-30181 September 17, 2024 20:24
@andieswift andieswift marked this pull request as ready for review September 17, 2024 20:24
@anyoussefinia anyoussefinia self-requested a review September 18, 2024 14:45
@anyoussefinia
Copy link
Collaborator

anyoussefinia commented Sep 19, 2024

PR looks good but the last deploy failed? Also added myself as a reviewer

@andieswift andieswift merged commit 43eea23 into bf-30181 Sep 20, 2024
13 of 14 checks passed
@andieswift andieswift deleted the as-30181 branch September 20, 2024 15:36
bflynn-cms added a commit that referenced this pull request Oct 20, 2024
… Application (#1512)

* started base UI componets for banner & card, not tested, still need to style

* first go on system notifications

* first shot at user notifications

* dismissUserNotification api + unit tests

* adding api for creating user notifications

* lint fix

* return created items when creating user notifications

* updating styling to match mockups, added tests for components (#1504)

* remove double layer of status code and body

* make create pass id (email) as a url token

* added the notificationAPI, added test, updated components slightly to work with be,  added user nots to context

* added local storage so notification stays on refresh, remove storage on logout:)

* dismiss existing notifications upon login

---------

Co-authored-by: Brandon Flynn <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants