-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ui): Updating @cmsgov/design-system v.4 to v.11 #1537
Open
andieswift
wants to merge
9
commits into
develop
Choose a base branch
from
ui-lib-update
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Endpoint URL - Environment not yet deployed, delete this comment and run the Pull Request workflow again after deploy is complete |
andieswift
had a problem deploying
to
ui-lib-update
October 23, 2024 23:25 — with
GitHub Actions
Failure
andieswift
had a problem deploying
to
ui-lib-update
October 30, 2024 20:29 — with
GitHub Actions
Failure
andieswift
force-pushed
the
ui-lib-update
branch
from
November 1, 2024 20:38
a67c7fd
to
34574e9
Compare
andieswift
had a problem deploying
to
ui-lib-update
November 1, 2024 20:42 — with
GitHub Actions
Failure
andieswift
had a problem deploying
to
ui-lib-update
November 4, 2024 22:24 — with
GitHub Actions
Failure
andieswift
had a problem deploying
to
ui-lib-update
November 5, 2024 16:15 — with
GitHub Actions
Failure
andieswift
requested review from
Dark-Knight-1313,
kristin-at-theta and
bflynn-cms
as code owners
November 5, 2024 16:51
andieswift
had a problem deploying
to
ui-lib-update
November 5, 2024 16:51 — with
GitHub Actions
Failure
andieswift
had a problem deploying
to
ui-lib-update
November 5, 2024 17:08 — with
GitHub Actions
Failure
andieswift
had a problem deploying
to
ui-lib-update
November 5, 2024 18:59 — with
GitHub Actions
Failure
andieswift
had a problem deploying
to
ui-lib-update
November 6, 2024 14:44 — with
GitHub Actions
Failure
anyoussefinia
approved these changes
Nov 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New formatting looks better IMO
andieswift
had a problem deploying
to
ui-lib-update
November 14, 2024 15:07 — with
GitHub Actions
Failure
andieswift
had a problem deploying
to
ui-lib-update
November 14, 2024 15:30 — with
GitHub Actions
Failure
andieswift
had a problem deploying
to
ui-lib-update
November 14, 2024 15:40 — with
GitHub Actions
Failure
andieswift
had a problem deploying
to
ui-lib-update
November 14, 2024 16:02 — with
GitHub Actions
Failure
andieswift
had a problem deploying
to
ui-lib-update
November 14, 2024 16:22 — with
GitHub Actions
Failure
andieswift
had a problem deploying
to
ui-lib-update
November 14, 2024 16:43 — with
GitHub Actions
Failure
andieswift
temporarily deployed
to
ui-lib-update
November 14, 2024 16:56 — with
GitHub Actions
Inactive
…eact packages, also made temp fix in scss file, and some ui component updates. still big broken
…ed in addition to the changes caused by using a new compiler
…e & got fonts rendering correctly
…d shes good to go
… dev dep bc of an issue with react script
andieswift
force-pushed
the
ui-lib-update
branch
from
December 11, 2024 18:26
15f2ec5
to
93abd47
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Story: https://qmacbis.atlassian.net/browse/OY2-29495
Endpoint: See github-actions bot comment
Details
Upgrade @cmsgov/design-system v.4 to v.11
Important Notes
🚫 DONT MERGE 🚫
This change effects the whole frontend, so it cannot be merged until thorough testing takes place.
Implementation Notes
Package Updates
upgraded packages
deleted packages
I removed a number of packages because they are not being used and/or no longer needed due to the upgrades. I used
depcheck
to find these packages and have tested on the frontend.Key Differences to Note
Top Nav Bar
Prior there was a purple line if the page had been visited before:
This is no more due to changes in cms-design
Media Queries
The sizes of media queries (screen-xl) has changed slightly. These 2 are screenshots of the same window but you can see the newer on is slightly narrower
Before:
After:
Typology
The sizes for headings, paragraphs and such have changed slightly. I matched the code, but that resulted in some components looking different. (if it was H1 I used the new equivalent heading-3xl, etc)
Example Package Dashboard Text before:
After:
Example Package details before:
After:
Accordions
Padding was removed on the accordion components
here is the FAQ before:
and after:
Test Plan
NOTE before we begin, the styling has changed slightly! In verifying this we don't need to check that the style matches EXACTLY (i.e. this font is 14px and it used to be 16px); but we want to ensure the look is similar and functions the same. i.e. If a button was blue before, it should still be blue
Future Thoughts
We are using
@material-ui/core"
which is no longer in use; they changed their name to mui. We may want to consider upgrading these components to use mui instead, or see if we can use the cms/design-system in place of them.