Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reverting the change: Removing the MMDL cards on new chip/spa #1565

Merged
merged 3 commits into from
Dec 12, 2024
Merged

Reverting the change: Removing the MMDL cards on new chip/spa #1565

merged 3 commits into from
Dec 12, 2024

Conversation

andieswift
Copy link
Collaborator

@andieswift andieswift commented Dec 11, 2024 •
edited
Loading

Story: https://jiraent.cms.gov/browse/OY2-31696
Endpoint: https://d3nmqq9h68oslv.cloudfront.net/

Details

  • added back MMDL card to Medicaid SPA:
Screenshot 2024-12-11 at 11 54 17 AM - with landing page when clicked: Screenshot 2024-12-11 at 11 56 18 AM - added back MMDL card for CHIP: Screenshot 2024-12-11 at 11 54 28 AM - which directs to this landing page: Screenshot 2024-12-11 at 11 55 48 AM

Changes

  • added back landing pages
  • added back routes to those pages
  • added back card which allowed clicking to the card

Implementation Notes

  • since we were told to pause work on MMDL and this was the only MMDL work not wrapped with LaunchDarkly, we are adding it back in for now as a temporary fix
  • In the future this feat should be wrapped in LaunchDarkly

Test Plan

  1. Click new submission
  2. Click CHIP or SPA
  3. Ensure the MMDL card exsists
  4. Make sure the landing page is correct

@andieswift andieswift self-assigned this Dec 11, 2024
@github-actions GitHub Actions
Copy link

Endpoint URL - Environment not yet deployed, delete this comment and run the Pull Request workflow again after deploy is complete

@andieswift andieswift marked this pull request as ready for review December 11, 2024 18:01
Dark-Knight-1313
Dark-Knight-1313 approved these changes Dec 11, 2024
View reviewed changes
Copy link
Collaborator

@Dark-Knight-1313 Dark-Knight-1313 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@andieswift andieswift merged commit a0b5244 into develop Dec 12, 2024
95 of 103 checks passed
@andieswift andieswift deleted the revert-mmdl branch December 12, 2024 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dark-Knight-1313 Dark-Knight-1313 Dark-Knight-1313 approved these changes

@kristin-at-theta kristin-at-theta Awaiting requested review from kristin-at-theta kristin-at-theta is a code owner

@bflynn-cms bflynn-cms Awaiting requested review from bflynn-cms bflynn-cms is a code owner

Assignees

@andieswift andieswift

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andieswift @Dark-Knight-1313