Pentest #1566
Merged
Pentest #1566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anyoussefinia
requested review from
Dark-Knight-1313,
kristin-at-theta and
bflynn-cms
as code owners
|
Endpoint URL - https://d108315ije1eu7.cloudfront.net |
anyoussefinia
temporarily deployed
to
pentest
GitHub Actions
Inactive
bflynn-cms
reviewed
Dec 13, 2024
| return false; | ||
| } | ||
|
|
||
| const allowedRoles = [ |
There was a problem hiding this comment.
thanks for turning this into a whitelist of allowed roles!
bflynn-cms
reviewed
Dec 13, 2024
| @@ -106,6 +106,7 @@ const UserManagement = () => { | |||
| console.log("Error while fetching user list.", error); | |||
| setAlertCode(RESPONSE_CODE[error.message]); | |||
| }); | |||
| // eslint-disable-next-line react-hooks/exhaustive-deps | |||
There was a problem hiding this comment.
please discard this change as no functional changes were made to this file
bflynn-cms
reviewed
Dec 13, 2024
| @@ -161,7 +161,7 @@ const UserPage = () => { | |||
| const { userProfile, setUserInfo, updatePhoneNumber, userRole, userStatus } = | |||
| useAppContext(); | |||
| const location = useLocation(); | |||
| const { userId } = useParams() ?? {}; | |||
| let { userId } = useParams() ?? {}; | |||
There was a problem hiding this comment.
curious why this change was made........might even be flagged by lint if setting with let but is never overridden.....but also probably userId is something we dont want to let get overwritten?
There was a problem hiding this comment.
you're right I did this when I was considering how to encrypt the email/userId before Andy fixed it
anyoussefinia
temporarily deployed
to
pentest
GitHub Actions
Inactive
bflynn-cms
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Story: https://jiraent.cms.gov/browse/OY2-31468
https://jiraent.cms.gov/browse/OY2-31474
Endpoint: https://d108315ije1eu7.cloudfront.net/
Details
added a batch function that modifies the idToken JWT with a "custom:user_roles" attribute with the roles retrieved for each user from dynamo.
Added route protection for the /usermanagement route which checks the jwt for proper role access
Changes
-also added the trigger function for potential use if the intermittent functionality problem is fixed.
Test Plan
Just a smoke test to make sure nothing is broken, The pen testers will need to verify that the usermanagent screen cannot be accessed by modifying the response to UserDataApi.userProfile by setting the admin role status from "revoked" to "active"