Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(finding-url): rendered the finding url for other products #223

Merged
merged 4 commits into from
Jul 23, 2024

Conversation

maira-samtek
Copy link
Collaborator

Purpose

This PR enables the link feature for products other than security hub

@maira-samtek maira-samtek requested a review from yonassrobi July 17, 2024 21:47
Copy link

@yonassrobi yonassrobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, it looks good to me. I've added two minor comments about handling split function.

src/macpro-security-hub-sync.ts Outdated Show resolved Hide resolved
src/macpro-security-hub-sync.ts Outdated Show resolved Hide resolved
@maira-samtek maira-samtek requested a review from yonassrobi July 18, 2024 21:34
Copy link

@yonassrobi yonassrobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for adding the length check.

@maira-samtek maira-samtek merged commit 185c3ae into main Jul 23, 2024
5 checks passed
Copy link

🎉 This PR is included in version 1.13.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@maira-samtek maira-samtek deleted the zarate-finding-url branch July 24, 2024 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants