fix

EnzymeAD · Oct 28, 2024 · 4e4ca89 · 4e4ca89
1 parent 182743c
commit 4e4ca89
Showing 1 changed file with 43 additions and 39 deletions.
diff --git a/enzyme/Enzyme/TypeAnalysis/TypeAnalysis.cpp b/enzyme/Enzyme/TypeAnalysis/TypeAnalysis.cpp
@@ -1033,34 +1033,36 @@ void TypeAnalyzer::updateAnalysis(Value *Val, TypeTree Data, Value *Origin) {
     assert(Origin);
     if (auto OI = dyn_cast<Instruction>(Origin)) {
       if (OI->getParent() != I->getParent()) {
-      if (!EnzymeStrictAliasing) {
-        if (!PDT.dominates(OI->getParent(), I->getParent())) {
-          bool allocationWithAllUsersInBlock = false;
-          if (auto AI = dyn_cast<AllocaInst>(I)) {
-            allocationWithAllUsersInBlock = true;
-            for (auto U : AI->users()) {
-              auto P = cast<Instruction>(U)->getParent();
-              if (P == OI->getParent())
-                continue;
-              if (PDT.dominates(OI->getParent(), P))
-                continue;
-              allocationWithAllUsersInBlock = false;
-              break;
+        if (!EnzymeStrictAliasing) {
+          if (!PDT.dominates(OI->getParent(), I->getParent())) {
+            bool allocationWithAllUsersInBlock = false;
+            if (auto AI = dyn_cast<AllocaInst>(I)) {
+              allocationWithAllUsersInBlock = true;
+              for (auto U : AI->users()) {
+                auto P = cast<Instruction>(U)->getParent();
+                if (P == OI->getParent())
+                  continue;
+                if (PDT.dominates(OI->getParent(), P))
+                  continue;
+                allocationWithAllUsersInBlock = false;
+                break;
+              }
             }
-          }
-          if (!allocationWithAllUsersInBlock) {
-            if (EnzymePrintType) {
-              llvm::errs() << " skipping update into ";
-              I->print(llvm::errs(), *MST);
-              llvm::errs() << " of " << Data.str() << " from ";
-              OI->print(llvm::errs(), *MST);
-              llvm::errs() << "\n";
+            if (!allocationWithAllUsersInBlock) {
+              if (EnzymePrintType) {
+                llvm::errs() << " skipping update into ";
+                I->print(llvm::errs(), *MST);
+                llvm::errs() << " of " << Data.str() << " from ";
+                OI->print(llvm::errs(), *MST);
+                llvm::errs() << "\n";
+              }
+              return;
             }
-            return;
           }
-        }
-      } else {
-          if (OI->getParent()->hasNPredecessors(1) && hasMetadata(OI->getParent()->getTerminator(), "enzyme_notypeprop")) {
+        } else {
+          if (OI->getParent()->hasNPredecessors(1) &&
+              hasMetadata(OI->getParent()->getTerminator(),
+                          "enzyme_notypeprop")) {
             if (EnzymePrintType) {
               llvm::errs() << " skipping update into ";
               I->print(llvm::errs(), *MST);
@@ -1072,25 +1074,27 @@ void TypeAnalyzer::updateAnalysis(Value *Val, TypeTree Data, Value *Origin) {
           }
         }
       }
-      }
+    }
   } else if (auto Arg = dyn_cast<Argument>(Val)) {
     assert(fntypeinfo.Function == Arg->getParent());
     if (auto OI = dyn_cast<Instruction>(Origin)) {
       auto I = &*fntypeinfo.Function->getEntryBlock().begin();
       if (OI->getParent() != I->getParent()) {
-      if (!EnzymeStrictAliasing) {
-        if (!PDT.dominates(OI->getParent(), I->getParent())) {
-          if (EnzymePrintType) {
-            llvm::errs() << " skipping update into ";
-            Arg->print(llvm::errs(), *MST);
-            llvm::errs() << " of " << Data.str() << " from ";
-            OI->print(llvm::errs(), *MST);
-            llvm::errs() << "\n";
+        if (!EnzymeStrictAliasing) {
+          if (!PDT.dominates(OI->getParent(), I->getParent())) {
+            if (EnzymePrintType) {
+              llvm::errs() << " skipping update into ";
+              Arg->print(llvm::errs(), *MST);
+              llvm::errs() << " of " << Data.str() << " from ";
+              OI->print(llvm::errs(), *MST);
+              llvm::errs() << "\n";
+            }
+            return;
           }
-          return;
-        }
-      } else {
-          if (OI->getParent()->hasNPredecessors(1) && hasMetadata(OI->getParent()->getTerminator(), "enzyme_notypeprop")) {
+        } else {
+          if (OI->getParent()->hasNPredecessors(1) &&
+              hasMetadata(OI->getParent()->getTerminator(),
+                          "enzyme_notypeprop")) {
             if (EnzymePrintType) {
               llvm::errs() << " skipping update into ";
               I->print(llvm::errs(), *MST);
@@ -1100,7 +1104,7 @@ void TypeAnalyzer::updateAnalysis(Value *Val, TypeTree Data, Value *Origin) {
             }
             return;
           }
-      }
+        }
       }
     }
   }