Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Truncate] Fix bug with fcmp handling #1847

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[Truncate] Fix bug with fcmp handling #1847

wants to merge 1 commit into from

Conversation

ivanradanov
Copy link
Collaborator

We did not pass the truncated values to the runtime

@ivanradanov
[Truncate] Fix bug with fcmp handling
a06a368 
We did not pass the truncated values to the runtime
wsmoses
wsmoses approved these changes Apr 28, 2024
View reviewed changes
Copy link
Member

@wsmoses wsmoses left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but maybe test?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wsmoses wsmoses wsmoses approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ivanradanov @wsmoses