[mlir] Summary-based activity analysis #2114
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ftynse
approved these changes
Oct 9, 2024
Comment on lines
+74
to
+79
| /// True iff all results differentially depend on all operands | ||
| // TODO: differential dependency/activity interface | ||
| // TODO: Select cond is not fully active | ||
| static bool isFullyActive(Operation *op) { | ||
| return isa<LLVM::FMulOp, LLVM::FAddOp, LLVM::FDivOp, LLVM::FSubOp, | ||
| LLVM::FNegOp, LLVM::FAbsOp, LLVM::SqrtOp, LLVM::SinOp, LLVM::CosOp, | ||
| LLVM::Exp2Op, LLVM::ExpOp, LLVM::LogOp, LLVM::InsertValueOp, | ||
| LLVM::ExtractValueOp, LLVM::BitcastOp, LLVM::SelectOp>(op); | ||
| } | ||
|
|
||
| static bool isNoOp(Operation *op) { | ||
| return isa<LLVM::NoAliasScopeDeclOp, LLVM::LifetimeStartOp, | ||
| LLVM::LifetimeEndOp, LLVM::AssumeOp>(op); | ||
| } |
There was a problem hiding this comment.
I suspect we have a copy of this elsewhere and would rather have one definition that is used in both, e.g., by having a static inline function in a header. Otherwise we run the risk of forgetting to update one of the copies and wondering why it doesn't work.
wsmoses
reviewed
Oct 9, 2024
| } | ||
|
|
||
| /// True iff all results differentially depend on all operands | ||
| // TODO: differential dependency/activity interface |
There was a problem hiding this comment.
So we do now have such an interface:
wsmoses
reviewed
Oct 11, 2024
pengmai
force-pushed
the
jmp/summary-activity
branch
3 times, most recently
from
b40b4d1 to
2e0a794
Compare
|
@pengmai I'm going to merge for now to avoid rebase issues, but comments above should be addressed subsequently |
pengmai
force-pushed
the
jmp/summary-activity
branch
from
2e0a794 to
d036184
Compare
pengmai
force-pushed
the
jmp/summary-activity
branch
from
d036184 to
63c2079
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.