Merge pull request #4062 from dkrupp/fixit_notes

[report-converter] FixIts from Clang-Tidy will be rendered as notes instead of events
Ericsson · Oct 27, 2023 · 08aec60 · 08aec60
2 parents 9f38b00 + 5d6605b
commit 08aec60
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 13 deletions.
diff --git a/tools/report-converter/codechecker_report_converter/analyzers/clang_tidy/parser.py b/tools/report-converter/codechecker_report_converter/analyzers/clang_tidy/parser.py
@@ -159,7 +159,7 @@ def _parse_fixits(
                 # a line number, and then a | character.
                 col = line.find(message_text) - line.find("|") - 1
 
-            report.bug_path_events.append(BugPathEvent(
+            report.notes.append(BugPathEvent(
                     f"{message_text} (fixit)",
                     report.file,
                     report.line,

diff --git a/tools/report-converter/tests/unit/analyzers/tidy_output_test_files/tidy3_cpp.plist b/tools/report-converter/tests/unit/analyzers/tidy_output_test_files/tidy3_cpp.plist
@@ -22,25 +22,24 @@
 				<key>line</key>
 				<integer>4</integer>
 			</dict>
-			<key>path</key>
+			<key>notes</key>
 			<array>
 				<dict>
-					<key>depth</key>
+				<key>location</key>
+				<dict>
+					<key>col</key>
+					<integer>12</integer>
+					<key>file</key>
 					<integer>0</integer>
-					<key>kind</key>
-					<string>event</string>
-					<key>location</key>
-					<dict>
-						<key>col</key>
-						<integer>12</integer>
-						<key>file</key>
-						<integer>0</integer>
-						<key>line</key>
-						<integer>4</integer>
+					<key>line</key>
+					<integer>4</integer>
 					</dict>
 					<key>message</key>
 					<string>nullptr (fixit)</string>
 				</dict>
+			</array>
+			<key>path</key>
+			<array>
 				<dict>
 					<key>depth</key>
 					<integer>0</integer>