[fix][clang-tidy] Fix env var replace for extra args #4033
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running codechecker and giving extra arguments for clang-tidy containing environmental variables fails. This issue seems to stem from that
env.replace_env_var
is use without an argument inanalyzer/codechecker_analyzer/analyzers/clangtidy/analyzer.py
. This should fix it.To reproduce the issue, run the following:
With the file
main.c
containing:and the file `.clangtidy_extra_flags.txt containing:
MY_ENV_VAR
This should fail with
TypeError: sequence item 1: expected str instance, function found