[report-converter] Support Clang 17.0+ FixIt in Clang-Tidy #4052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkrupp
force-pushed
the
fixit_support_clang17
branch
from
b03e840 to
a7fcd4a
Compare
whisperity
changed the title
whisperity
added
bugfix 🔨
tools 🛠️
whisperity
requested changes
Oct 24, 2023
tools/report-converter/codechecker_report_converter/analyzers/clang_tidy/parser.py
Outdated
Show resolved
Hide resolved
tools/report-converter/codechecker_report_converter/analyzers/clang_tidy/parser.py
Show resolved
Hide resolved
tools/report-converter/codechecker_report_converter/analyzers/clang_tidy/parser.py
Outdated
Show resolved
Hide resolved
tools/report-converter/codechecker_report_converter/analyzers/clang_tidy/parser.py
Outdated
Show resolved
Hide resolved
|
With the suggested changes, this looks fine for 6.23, but for 6.24 we should consider dropping the conversion from "random meaningless stdout text" to plist in favour of "well-formatted message and fix YAML" to plist. For a very long time now, Clang-Tidy was capable of dumping the structure of the created diagnostics (all the notes, warnings, and fixits, see https://github.com/llvm/llvm-project/blob/llvmorg-17.0.0/clang-tools-extra/test/clang-tidy/infrastructure/export-diagnostics.cpp!) in YAML. |
dkrupp
force-pushed
the
fixit_support_clang17
branch
from
a4b8e22 to
74a295e
Compare
clang-tidy version 17 introduced a new fixit diagnostic formatting. The report converter is now prepared to parse this new format. It also still supports the old format.
…clang_tidy/parser.py Co-authored-by: whisperity <[email protected]>
dkrupp
force-pushed
the
fixit_support_clang17
branch
from
74a295e to
3c1a426
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
clang-tidy version 17 introduced a new fixit diagnostic formatting. The report converter is now prepared to parse this new format. It also still supports the old format.
Fixes #4047