Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(config): Apply invariant fixes from label-tool #4291

Merged

Conversation

whisperity
Copy link
Contributor

Apply the automatic fixes of invariants such as "profile:sensitive and profile:extreme should be present if profile:default is present" and "guideline:sei-cert should be present if a sei-cert:RULE-01-like label is present" to the config files, as emitted by #4275.

@whisperity whisperity added clang sa 🐉 The Clang Static Analyzer is a source code analysis tool that finds bugs in C-family programs. clang-tidy 🐉 clang-tidy is a clang-based C++ “linter” tool. config ⚙️ cppcheck 🐞 CppCheck is a static analysis tool for C++ code labels Jul 9, 2024
@whisperity whisperity requested a review from dkrupp July 9, 2024 17:41
Copy link
Contributor Author

@whisperity whisperity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bruntib @dkrupp @vodorok I'm not sure if this should go into 6.25 only, or 6.24.1 as well.

@@ -1077,6 +1076,7 @@
],
"unix.cstring.NullArg": [
"doc_url:https://clang.llvm.org/docs/analyzer/checkers.html#unix-cstring-nullarg-c",
"guideline:sei-cert",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the only behavioural change, but if someone uses analyse --disable default --enable guideline:sei-cert (or however it should be specified...) then they will start seeing this checker, which changes the potentially reported set of bugs.

@whisperity whisperity added the label-tool 🔖 Related to tooling that manages the analyzer/checker label configuration label Jul 9, 2024
@whisperity whisperity added this to the release 6.24.1 milestone Jul 9, 2024
@bruntib bruntib merged commit 9693dbb into Ericsson:master Aug 13, 2024
7 of 9 checks passed
@whisperity whisperity deleted the chore/config/fix-checker-label-invariants branch August 13, 2024 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clang sa 🐉 The Clang Static Analyzer is a source code analysis tool that finds bugs in C-family programs. clang-tidy 🐉 clang-tidy is a clang-based C++ “linter” tool. config ⚙️ cppcheck 🐞 CppCheck is a static analysis tool for C++ code label-tool 🔖 Related to tooling that manages the analyzer/checker label configuration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants