Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cfg] Update labels file for updated checkers #4383

Merged
merged 6 commits into from
Nov 27, 2024
Merged

[cfg] Update labels file for updated checkers #4383

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
9c74782
[cfg] Update labels file for updated checkers
gamesh411 Nov 21, 2024
09fb4bd
add cppcheck and clang-tidy checks
gamesh411 Nov 22, 2024
1c93f14
put more tidy check in profiles
gamesh411 Nov 25, 2024
0325ddf
readd simplestream, enable unix.stream
gamesh411 Nov 25, 2024
8b6c5d9
readd docs for alias checkers
gamesh411 Nov 27, 2024
98ed30c
add union check to default profile
gamesh411 Nov 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
62 changes: 62 additions & 0 deletions config/labels/analyzers/clang-tidy.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,6 +157,10 @@
"doc_url:https://clang.llvm.org/extra/clang-tidy/checks/android/comparison-in-temp-failure-retry.html",
"severity:MEDIUM"
],
"boost-use-ranges": [
"doc_url:https://clang.llvm.org/extra/clang-tidy/checks/boost/use-ranges.html",
"severity:LOW"
],
"boost-use-to-string": [
"doc_url:https://clang.llvm.org/extra/clang-tidy/checks/boost/use-to-string.html",
"profile:extreme",
Expand Down Expand Up @@ -194,6 +198,10 @@
"sei-cert:pos44-c",
"severity:MEDIUM"
],
"bugprone-bitwise-pointer-cast": [
dkrupp marked this conversation as resolved.
Show resolved Hide resolved
"doc_url:https://clang.llvm.org/extra/clang-tidy/checks/bugprone/bitwise-pointer-cast.html",
"severity:MEDIUM"
],
"bugprone-bool-pointer-implicit-conversion": [
"doc_url:https://clang.llvm.org/extra/clang-tidy/checks/bugprone/bool-pointer-implicit-conversion.html",
"profile:default",
Expand Down Expand Up @@ -453,6 +461,10 @@
"profile:sensitive",
"severity:MEDIUM"
],
"bugprone-nondeterministic-pointer-iteration-order": [
"doc_url:https://clang.llvm.org/extra/clang-tidy/checks/bugprone/nondeterministic-pointer-iteration-order.html",
"severity:MEDIUM"
],
"bugprone-optional-value-conversion": [
"doc_url:https://clang.llvm.org/extra/clang-tidy/checks/bugprone/optional-value-conversion.html",
"profile:default",
Expand All @@ -466,6 +478,10 @@
"profile:sensitive",
"severity:MEDIUM"
],
"bugprone-pointer-arithmetic-on-polymorphic-object": [
dkrupp marked this conversation as resolved.
Show resolved Hide resolved
"doc_url:https://clang.llvm.org/extra/clang-tidy/checks/bugprone/pointer-arithmetic-on-polymorphic-object.html",
"severity:HIGH"
],
"bugprone-posix-return": [
"doc_url:https://clang.llvm.org/extra/clang-tidy/checks/bugprone/posix-return.html",
"profile:extreme",
Expand All @@ -487,6 +503,10 @@
"sei-cert:dcl51-cpp",
"severity:LOW"
],
"bugprone-return-const-ref-from-parameter": [
"doc_url:https://clang.llvm.org/extra/clang-tidy/checks/bugprone/return-const-ref-from-parameter.html",
"severity:MEDIUM"
dkrupp marked this conversation as resolved.
Show resolved Hide resolved
],
"bugprone-shared-ptr-array-mismatch": [
"doc_url:https://clang.llvm.org/extra/clang-tidy/checks/bugprone/shared-ptr-array-mismatch.html",
"guideline:sei-cert",
Expand Down Expand Up @@ -643,6 +663,10 @@
"profile:sensitive",
"severity:MEDIUM"
],
"bugprone-tagged-union-member-count": [
dkrupp marked this conversation as resolved.
Show resolved Hide resolved
"doc_url:https://clang.llvm.org/extra/clang-tidy/checks/bugprone/tagged-union-member-count.html",
"severity:MEDIUM"
],
"bugprone-suspicious-stringview-data-usage": [
"doc_url:https://clang.llvm.org/extra/clang-tidy/checks/bugprone/suspicious-stringview-data-usage.html",
"profile:default",
Expand Down Expand Up @@ -788,6 +812,13 @@
"profile:sensitive",
"severity:MEDIUM"
],
"cert-arr39-c": [
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this checker is an alias of the bugprone-sizeof-expression.
To avoid duplicate findings, we just add the main checker to the profiles and the guidelines. So please move these to the bugprone-sizeof-expression.
"guideline:sei-cert",
"profile:security",
"sei-cert:arr39-c",

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

moving there, this and the bugprone-sizeof-expression is also quite noisy

"doc_url:https://clang.llvm.org/extra/clang-tidy/checks/cert/arr39-c.html",
"guideline:sei-cert",
"profile:security",
"sei-cert:arr39-c",
"severity:HIGH"
],
"cert-con36-c": [
"doc_url:https://clang.llvm.org/extra/clang-tidy/checks/cert/con36-c.html",
"severity:MEDIUM"
Expand All @@ -796,6 +827,13 @@
"doc_url:https://clang.llvm.org/extra/clang-tidy/checks/cert/con54-cpp.html",
"severity:MEDIUM"
],
"cert-ctr56-cpp": [
"doc_url:https://clang.llvm.org/extra/clang-tidy/checks/cert/ctr56-cpp.html",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is just an alias checker please move teh guideline and sei-cert profile correspondence to
checker
bugprone-pointer-arithmetic-on-polymorphic-object

"guideline:sei-cert",
"profile:security",
"sei-cert:ctr56-cpp",
"severity:MEDIUM"
],
"cert-dcl03-c": [
"doc_url:https://clang.llvm.org/extra/clang-tidy/checks/cert/dcl03-c.html",
"guideline:sei-cert",
Expand Down Expand Up @@ -6732,6 +6770,10 @@
"profile:sensitive",
"severity:LOW"
],
"misc-use-internal-linkage": [
"doc_url:https://clang.llvm.org/extra/clang-tidy/checks/misc/use-internal-linkage.html",
"severity:LOW"
],
"misc-virtual-near-miss": [
"doc_url:https://releases.llvm.org/6.0.1/tools/clang/tools/extra/docs/clang-tidy/checks/misc-virtual-near-miss.html",
"profile:default",
Expand Down Expand Up @@ -6785,6 +6827,10 @@
"profile:extreme",
"severity:LOW"
],
"modernize-min-max-use-initializer-list": [
"doc_url:https://clang.llvm.org/extra/clang-tidy/checks/modernize/min-max-use-initializer-list.html",
"severity:LOW"
],
"modernize-pass-by-value": [
"doc_url:https://clang.llvm.org/extra/clang-tidy/checks/modernize/pass-by-value.html",
"profile:extreme",
Expand Down Expand Up @@ -6897,11 +6943,19 @@
"profile:extreme",
"severity:LOW"
],
"modernize-use-ranges": [
"doc_url:https://clang.llvm.org/extra/clang-tidy/checks/modernize/use-ranges.html",
"severity:LOW"
],
"modernize-use-starts-ends-with": [
"doc_url:https://clang.llvm.org/extra/clang-tidy/checks/modernize/use-starts-ends-with.html",
"profile:extreme",
"severity:LOW"
],
"modernize-use-std-format": [
"doc_url:https://clang.llvm.org/extra/clang-tidy/checks/modernize/use-std-format.html",
"severity:LOW"
],
"modernize-use-std-numbers": [
"doc_url:https://clang.llvm.org/extra/clang-tidy/checks/modernize/use-std-numbers.html",
"profile:extreme",
Expand Down Expand Up @@ -7117,6 +7171,14 @@
"doc_url:https://clang.llvm.org/extra/clang-tidy/checks/portability/std-allocator-const.html",
"severity:STYLE"
],
"portability-template-virtual-member-function": [
"doc_url:https://clang.llvm.org/extra/clang-tidy/checks/portability/template-virtual-member-function.html",
"severity:MEDIUM"
],
"readability-math-missing-parentheses": [
"doc_url:https://clang.llvm.org/extra/clang-tidy/checks/readability/math-missing-parentheses.html",
"severity:LOW"
],
"readability-avoid-const-params-in-decls": [
"doc_url:https://clang.llvm.org/extra/clang-tidy/checks/readability/avoid-const-params-in-decls.html",
"severity:STYLE"
Expand Down
73 changes: 65 additions & 8 deletions config/labels/analyzers/clangsa.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,14 +248,9 @@
"profile:sensitive",
"severity:HIGH"
],
"alpha.security.taint.TaintPropagation": [
"doc_url:https://clang.llvm.org/docs/analyzer/checkers.html#alpha-security-taint-taintpropagation-c-c",
"profile:extreme",
"profile:sensitive",
"severity:HIGH"
],
"alpha.unix.BlockInCriticalSection": [
"unix.BlockInCriticalSection": [
"doc_url:https://clang.llvm.org/docs/analyzer/checkers.html#alpha-unix-blockincriticalsection-c",
"profile:default",
"profile:extreme",
"profile:sensitive",
"severity:LOW"
Expand All @@ -278,7 +273,7 @@
"profile:sensitive",
"severity:HIGH"
],
"alpha.unix.SimpleStream": [
"unix.SimpleStream": [
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe to profile:default depending how noisy it is

"doc_url:https://clang.llvm.org/docs/analyzer/checkers.html#alpha-unix-simplestream-c",
"profile:extreme",
"severity:MEDIUM"
Expand Down Expand Up @@ -774,6 +769,30 @@
"sei-cert:mem30-c",
"severity:MEDIUM"
],
"optin.taint.GenericTaint": [
"doc_url:https://clang.llvm.org/docs/analyzer/checkers.html#optin-taint-generictaint-c-c",
"profile:extreme",
"profile:sensitive",
"severity:HIGH"
],
"optin.taint.TaintedAlloc": [
"doc_url:https://clang.llvm.org/docs/analyzer/checkers.html#optin-taint-taintedalloc-c-c",
"profile:extreme",
"profile:sensitive",
"severity:HIGH"
],
"optin.taint.TaintedDiv": [
"doc_url:https://clang.llvm.org/docs/analyzer/checkers.html#optin-taint-tainteddiv-c-c-objc",
"profile:extreme",
"profile:sensitive",
"severity:HIGH"
],
"optin.taint.TaintPropagation": [
"doc_url:https://clang.llvm.org/docs/analyzer/checkers.html#optin-taint-generictaint-c-c",
"profile:extreme",
"profile:sensitive",
"severity:HIGH"
],
"osx.API": [
"doc_url:https://clang.llvm.org/docs/analyzer/checkers.html#osx-api-c"
],
Expand Down Expand Up @@ -869,6 +888,44 @@
"sei-cert:flp30-c",
"severity:MEDIUM"
],
"security.MmapWriteExec": [
"doc_url:https://clang.llvm.org/docs/analyzer/checkers.html#security-mmapwriteexec-c",
"profile:default",
"profile:extreme",
"profile:security",
"profile:sensitive",
"severity:MEDIUM"
],
"security.PointerSub": [
"doc_url:https://clang.llvm.org/docs/analyzer/checkers.html#security-pointersub-c",
"guideline:sei-cert",
"profile:default",
"profile:extreme",
"profile:security",
"profile:sensitive",
"sei-cert:arr36-c",
"severity:HIGH"
],
"security.PutenvStackArray": [
"doc_url:https://clang.llvm.org/docs/analyzer/checkers.html#security-putenvstackarray-c",
"guideline:sei-cert",
"profile:default",
"profile:extreme",
"profile:security",
"profile:sensitive",
"sei-cert:pos34-c",
"severity:HIGH"
],
"security.SetgidSetuidOrder": [
"doc_url:https://clang.llvm.org/docs/analyzer/checkers.html#security-setgidsetuidorder-c",
"guideline:sei-cert",
"profile:default",
"profile:extreme",
"profile:security",
"profile:sensitive",
"sei-cert:pos36-c",
"severity:MEDIUM"
],
"security.cert.env.InvalidPtr": [
"doc_url:https://clang.llvm.org/docs/analyzer/checkers.html#security-cert-env-invalidptr",
"guideline:sei-cert",
Expand Down
15 changes: 15 additions & 0 deletions config/labels/analyzers/cppcheck.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -350,6 +350,12 @@
"profile:sensitive",
"severity:HIGH"
],
"cppcheck-eraseIteratorOutOfBounds": [
"severity:HIGH"
],
"cppcheck-eraseIteratorOutOfBoundsCond": [
"severity:HIGH"
],
"cppcheck-exceptDeallocThrow": [
"profile:default",
"profile:extreme",
Expand Down Expand Up @@ -1484,6 +1490,15 @@
"cppcheck-uselessCallsSwap": [
"severity:LOW"
],
"cppcheck-uselessOverride": [
"severity:STYLE"
],
"cppcheck-returnByReference": [
"severity:LOW"
],
"cppcheck-suspiciousFloatingPointCast": [
"severity:STYLE"
],
"cppcheck-va_end_missing": [
"profile:default",
"profile:extreme",
Expand Down
Loading