Restructure Github actions, update PDK 3.0.1, spec fixes #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anders-larsson
force-pushed
the
restructure_actions
branch
3 times, most recently
from
9c8b9e9 to
4a88ae3
Compare
anders-larsson
changed the title
anders-larsson
force-pushed
the
restructure_actions
branch
2 times, most recently
from
1b0da1d to
50d2d02
Compare
anders-larsson
force-pushed
the
restructure_actions
branch
9 times, most recently
from
2a16ed2 to
4017fb3
Compare
anders-larsson
force-pushed
the
restructure_actions
branch
from
4017fb3 to
d7657bc
Compare
anders-larsson
changed the title
|
@Phil-Friderici I cannot add you as a reviewer here (apparently). Can you have a look? Thanks. |
|
I like to start using https://github.com/kodguru/action-pdk-test-unit :) Looks good to me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure how it passed before but vas_fqdn was undef and it caused checks to fail. Setting
let(:node) { }on tests now.Using our own variant of action-pdk-test-unit at kodguru/action-pdk-test-unit@buildtools which includes gcc and make to ensure we can build the native extensions required for webmock.