Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support all documented aliases #2733

Merged
merged 1 commit into from
Dec 14, 2024
Merged

Support all documented aliases #2733

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/vsix.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ jobs:
mkdir vsix
7z x src/GUI/lib/efreveng80.exe.zip -oefreveng80 -y
dir /a:-d /s /b "efreveng80" | find /c ":\" > filecount.txt
findstr "164" filecount.txt
findstr "165" filecount.txt

- name: Extract and verify efreveng90.exe.zip file count
if: github.event_name != 'pull_request'
Expand All @@ -67,7 +67,7 @@ jobs:
mkdir vsix
7z x src/GUI/lib/efreveng90.exe.zip -oefreveng90 -y
dir /a:-d /s /b "efreveng90" | find /c ":\" > filecount.txt
findstr "147" filecount.txt
findstr "148" filecount.txt

- name: Setup MSBuild.exe
uses: microsoft/setup-msbuild@v2
Expand Down
8 changes: 8 additions & 0 deletions src/GUI/Shared/Helpers/SqlConnectionStringBuilderHelper.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,16 @@ public SqlConnectionStringBuilder GetBuilder(string connectionString)

private string ReplaceMdsKeywords(string connectionString)
{
// https://github.com/dotnet/SqlClient/blob/main/release-notes/2.0/2.0.0.md#new-connection-string-property-synonyms
connectionString = connectionString.Replace("Application Intent=", "ApplicationIntent=");
connectionString = connectionString.Replace("Connect Retry Count=", "ConnectRetryCount=");
connectionString = connectionString.Replace("Connect Retry Interval=", "ConnectRetryInterval=");
connectionString = connectionString.Replace("Pool Blocking Period=", "PoolBlockingPeriod=");
connectionString = connectionString.Replace("Multiple Active Result Sets=", "MultipleActiveResultSets=");
connectionString = connectionString.Replace("Multi Subnet Failover=", "MultiSubnetFailover=");
connectionString = connectionString.Replace("Transparent Network IP Resolution=", "TransparentNetworkIPResolution=");
connectionString = connectionString.Replace("Trust Server Certificate=", "TrustServerCertificate=");

return connectionString;
}
}
Expand Down