Use sweep_write when changing brightness #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change uses https://docs.rs/blight/latest/blight/struct.Device.html#method.sweep_write for adjusting brightness as well as reusing the `Device`. Signed-off-by: Daniel Hodges <[email protected]>
|
I'll look at this later tonight. Don't be afraid to ping me if I forget :) Thanks for your patience |
ErikReider
requested changes
Jul 15, 2023
Comment on lines
-274
to
-277
| // Limits the lowest brightness to 5% | ||
| if change / max < (brightness_delta as f64) * 0.01 { | ||
| return Ok(Some(device)); | ||
| } |
There was a problem hiding this comment.
Removing this doesn't limit the brightness to the lower 5%
Comment on lines
-281
to
+273
| match change_bl(brightness_delta, Change::Regular, direction, None) { | ||
| match device.sweep_write(change, Delay::default()) { |
There was a problem hiding this comment.
The issue with the sweep function is that it's blocking the main thread, i.e. the overlay change gets delayed until the sweep has completed.
Did the change to sweep_write fix #12 or was it the logic above?
There was a problem hiding this comment.
I think the logic helps, but it doesn't properly change by the amount for some reason. I think you are probably right about blocking the main thread. I'll play around with it sometime when it bothers me more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change uses https://docs.rs/blight/latest/blight/struct.Device.html#method.sweep_write for adjusting brightness as well as reusing the
Device. This should resolve #12.