Fix automatic warnings on AutoMod-blocked messages for forum channels #225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Erisa
approved these changes
Sep 1, 2024
Also adds handling for when this config value is missing
Erisa
approved these changes
Sep 1, 2024
FloatingMilkshake
deleted the
floatingmilkshake/automod-autowarn-forum-fix
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #224.
Previously when AutoMod would block thread creation in a forum channel (original message matched a filter), Cliptok would catch the AutoMod block and attempt to send its automatic warning message directly into the forum channel—this would fail, because you cannot send a text message into a
GuildForumchannel. Thus the entire warning would fail. This PR adds a configurable fallback channel (forumChannelAutoWarnFallbackChannelin config.json) that is used for warning messages where the warning is in response to an AutoMod-blocked message in aGuildForumchannel.(Note that for messages inside an already-created thread, the warning message is sent in the thread—those have different channel types, like
PublicThreadandPrivateThread.)