V.next merged with main #1701
Merged
V.next merged with main #1701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This hides a little (i) button in the callout that does not lead to anywhere. This is already hidden in the C++ sample so needs to be marked as hidden in QML as well.
* add template files * Update templates to 100.15
* Fix C++ deprecations * Review feedback
* remove spaces from event names * Fix logic in GAnalytics class, add more member vars * Commit suggestions from code review * Add language event parameter
* Add patch version * ARCGIS_RUNTIME_VERSION * toolkit * QML imports * README update * Fix table of contents
* Add samples.pro * Add blank line at end
* Redo the C++ samples with max extent * add toggle switch * Add C++ screenshot and readme * reset the viewpoint when max extent is toggled back on * Add QML sample * add SetMaxExtent to sample viewer * Add use case to read me * updte version number to include patch number * fixup! updte version number to include patch number * Rename directory to capitalize first letter * Code review feedback * Delete ArcGISRuntimeSDKQt_CppSamples/Maps/setMaxExtent directory * Update name casing * Update UI switch colors to match the sample viewer * More CR feedbackg * Update ArcGISRuntimeSDKQt_QMLSamples/Maps/SetMaxExtent/README.metadata.json Co-authored-by: Tanner Yould <[email protected]> * Update ArcGISRuntimeSDKQt_CppSamples/Maps/SetMaxExtent/README.metadata.json Co-authored-by: Tanner Yould <[email protected]> Co-authored-by: Tanner Yould <[email protected]>
* Initial C++ commit * Initial QML commit * Initialize IPS class * Add indoor positioning helper class * rename cpp file * rename header * rename files * add wrapper class * add debugging info * Cleanup code * Update READMEs and metadata * Cleanup UI and add comments * add to sample viewers * Add screenshot * Address C++ code review * address QML code review * update pass by const ref style Co-authored-by: James Ballard <[email protected]> * Apply suggestions from code review Co-authored-by: Gela <[email protected]> * Implement requested changes from code review * update webmap data source Co-authored-by: James Ballard <[email protected]> Co-authored-by: Gela <[email protected]>
* Register IndoorsLocationDataSourceCreator files for C++ * IndoorsLocationDataSourceCreator formatting change
* Initial C++ commit * additional C++ work * C++ done * Initial QML commit * Remove API key * Add QML sample * Rename download to export * Update metadata * Add comments * Add sample to sample viewers * Clean up C++ sample * Fix QML formatting * add download pngs * Apply suggestions from code review Co-authored-by: Gela <[email protected]> * Apply changes from code review comments * Apply suggestion from code review Co-authored-by: Gela <[email protected]> * Fix JSON * C++ allow cancel/reset and overhaul UI * Added cancel, reset, and UI changes * Remove download icon and update screenshot * Apply suggestions from code review Co-authored-by: Gela <[email protected]> * Respond to code feedback * Fix export crash bug * Apply suggestions from code review Co-authored-by: Gela <[email protected]> * Fix export crash bug * check vt load status before setting url * Check for existing geometry before creating a new one * Update ArcGISRuntimeSDKQt_QMLSamples/Layers/ExportVectorTiles/README.md Co-authored-by: Gela <[email protected]> * Update ArcGISRuntimeSDKQt_CppSamples/Layers/ExportVectorTiles/README.md Co-authored-by: Gela <[email protected]> Co-authored-by: Gela <[email protected]>
* rename C++ sample * fixup! rename C++ sample * Rename QML sample * Rename samples in sample viewer
* update CQL-JSON in C++ sample * update CQL-JSON in QML sample
* Add bluetooth info to Info.plist * Fix logic error
* Add QStandardPaths includes * Wrap in #ifdef
…1444) * Adds the IndoorsLocationDataSourceCreator source files to the json * Add header extension
* Initial C++ commit * initial cpp work * Add FeatureListModel * Cpp logic works * Further cpp fixes * Commit feature list model class * cpp ui cleanup * initial QML commit * Update C++ implementation * Complete QML implementation * Add comments, README, metadata * Add sample to sample viewers * Add feature list model and fix feature count in UI * Apply suggestions from code review Co-authored-by: Gela <[email protected]> * Apply suggestions from code review * Apply suggestions from code review Co-authored-by: Gela <[email protected]> Co-authored-by: Gela <[email protected]>
* add clustering sample * fix default values * add popup * fix github check * Apply suggestions from code review Co-authored-by: Tanner Yould <[email protected]> Co-authored-by: James Ballard <[email protected]> * fix review * fix review * fix comments * remove popup manager declaration --------- Co-authored-by: Tanner Yould <[email protected]> Co-authored-by: James Ballard <[email protected]>
* add android x86_64 * fix path
* update to use PortalUser async API * Mistake, there wasn't actually a bug. I just wasnt patient enough for the fetch to complete * move include to correct spot * James PR * README
* SearchForWebmap * ShowOrgBasemaps * INtegratedWindowsAuthentication * doc fix
* callout added to dynamic entity * Update ArcGISRuntimeSDKQt_CppSamples/Layers/AddDynamicEntityLayer/AddDynamicEntityLayer.cpp Co-authored-by: James Ballard <[email protected]> * review comments fixed. * cleanup * review comment fixed * showed the callout only when the title is available. * dynamic entity path added. --------- Co-authored-by: James Ballard <[email protected]>
* retry load if failed * simplify
* Fix for wrong busy indicator for ShowOrgBasemaps * review comment fixed.
* Change for anonymous sign-in to do not challenge * review comment fixed. * review comment fix.
* updating cluster samples to include cluster highlighting * change in verbiage * changing default behavior to true based on a discussion with Preeti.
* no message * redundant clear * forgot comment when moved.
Co-authored-by: Tanner Yould <[email protected]>
JamesMBallard
approved these changes
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@JamesMBallard please review
I've spot checked throughout and did a test build of the viewer