-
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-129 Send level-up on same channel and remove after 5 seconds. #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imDMK
requested changes
Oct 25, 2023
.../java/com/eternalcode/discordapp/leveling/experience/listener/ExperienceMessageListener.java
Outdated
Show resolved
Hide resolved
...java/com/eternalcode/discordapp/leveling/experience/listener/ExperienceReactionListener.java
Outdated
Show resolved
Hide resolved
...java/com/eternalcode/discordapp/leveling/experience/listener/ExperienceReactionListener.java
Outdated
Show resolved
Hide resolved
...in/java/com/eternalcode/discordapp/leveling/experience/listener/ExperienceVoiceListener.java
Outdated
Show resolved
Hide resolved
src/main/java/com/eternalcode/discordapp/leveling/games/CodeGameAnswerController.java
Outdated
Show resolved
Hide resolved
src/main/java/com/eternalcode/discordapp/leveling/LevelController.java
Outdated
Show resolved
Hide resolved
imDMK
approved these changes
Oct 25, 2023
Rollczi
reviewed
Oct 25, 2023
...java/com/eternalcode/discordapp/leveling/experience/listener/ExperienceReactionListener.java
Outdated
Show resolved
Hide resolved
Rollczi
approved these changes
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes GH-129
Why?
Because to recude spam at the channels.
Working
2023-10-25.19-39-28.mov
READ-ME
Sure, you might wonder why the level-up message from a reaction is sent via DM. This is because, let's assume that a user received a level-up notification in the announcements channel; in that case, the level-up message would be sent on that channel, which is something we'd prefer to avoid. That's why I send the level-up message from the reaction via DM.