This repository has been archived by the owner on Aug 21, 2024. It is now read-only.
dev to int: Fix scene loading #10910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix collider reactivity * fix tests * optimize
* Upload drag drop files MT fix * Array length check
* feat: refactor magic link email template to support desktop and mobile chore: layout template to reuse styles in other templates * Fixed logo link --------- Co-authored-by: Hanzla Mateen <[email protected]>
* Fixed bugs in instanceserver connections
There were still some bugs surrounding a client connecting to an
instanceserver if the instance record for that server no longer
existed. updateInstance needed to return false in that situation.
This still led to a situation where the client would be stuck trying
to authenticate forever. Added a step prior to authentication where
the client listens for a message with { instanceReady: true }, which
is sent by setupSocketFunctions. If the server isn't ready within
10 seconds, then it returns { instanceReady: false }, and the client
will do a new instanceserver provision and hopefully connect properly
this time.
* make eslint happy
---------
Co-authored-by: Josh Field <[email protected]>
* apply proper offsets to select * add x offset calculation * fix offset in select
* match tooltip with figma design * fix check-errors * fix check errors * match title background with figma * fix check errors * fix check errors --------- Co-authored-by: Appaji <[email protected]>
Co-authored-by: Aditya Mitra <[email protected]>
* set up observer api * add asset infinite scroll with observer api * clean up * fix categorie change * remove table pagination code * add infinite scroll in assets container * keep calling api till element is in view --------- Co-authored-by: aditya-mitra <[email protected]>
* swap lit unlit title * flip lit and unlit icon --------- Co-authored-by: Liam Broza <[email protected]>
* update aseet tree bg and padding * update h on desph * padding * some padding change * assset height cleanup * fix font size * fix tolbar
* restrct file name to 64 characters * bake length search into regex , remove unused regex * remove comments
…lly loaded (#10903) Co-authored-by: lonedevr <[email protected]>
dinomut1
requested review from
MichaelEstes,
speigg,
hanzlamateen,
aditya-mitra,
SYBIOTE,
CITIZENDOT and
AidanCaruso
as code owners
dinomut1
added a commit
that referenced
this pull request
Aug 7, 2024
* dev to int (#10901) * Revert "Physics reactivity for collider component updates and order dependenc…" (#10876) This reverts commit 33afb3b. * fix collider reactivity (#10877) * fix collider reactivity * fix tests * optimize * fix duplicate new scene (#10880) * rigidbody initialization quick fix (#10883) * Upload drag drop files MT fix (#10881) * Upload drag drop files MT fix * Array length check * LerpTransform from rigid body uses rigid body instead of scene entity (#10882) * remove old workflows (#10886) * fix rigidbody crash server (#10891) * IR-3561: Magic Link template support for mobile and desktop (#10889) * feat: refactor magic link email template to support desktop and mobile chore: layout template to reuse styles in other templates * Fixed logo link --------- Co-authored-by: Hanzla Mateen <[email protected]> * Fixed bugs in instanceserver connections (#10887) * Fixed bugs in instanceserver connections There were still some bugs surrounding a client connecting to an instanceserver if the instance record for that server no longer existed. updateInstance needed to return false in that situation. This still led to a situation where the client would be stuck trying to authenticate forever. Added a step prior to authentication where the client listens for a message with { instanceReady: true }, which is sent by setupSocketFunctions. If the server isn't ready within 10 seconds, then it returns { instanceReady: false }, and the client will do a new instanceserver provision and hopefully connect properly this time. * make eslint happy --------- Co-authored-by: Josh Field <[email protected]> * ignore hash when checking cache validity (#10900) --------- Co-authored-by: Josh Field <[email protected]> Co-authored-by: Michael Estes <[email protected]> Co-authored-by: Daniel Belmes <[email protected]> Co-authored-by: lucas3900 <[email protected]> Co-authored-by: Kyle Baran <[email protected]> Co-authored-by: José Galván <[email protected]> Co-authored-by: Hanzla Mateen <[email protected]> * dev to int: Fix scene loading (#10910) * Revert "Physics reactivity for collider component updates and order dependenc…" (#10876) This reverts commit 33afb3b. * fix collider reactivity (#10877) * fix collider reactivity * fix tests * optimize * fix duplicate new scene (#10880) * rigidbody initialization quick fix (#10883) * Upload drag drop files MT fix (#10881) * Upload drag drop files MT fix * Array length check * LerpTransform from rigid body uses rigid body instead of scene entity (#10882) * remove old workflows (#10886) * fix rigidbody crash server (#10891) * IR-3561: Magic Link template support for mobile and desktop (#10889) * feat: refactor magic link email template to support desktop and mobile chore: layout template to reuse styles in other templates * Fixed logo link --------- Co-authored-by: Hanzla Mateen <[email protected]> * Fixed bugs in instanceserver connections (#10887) * Fixed bugs in instanceserver connections There were still some bugs surrounding a client connecting to an instanceserver if the instance record for that server no longer existed. updateInstance needed to return false in that situation. This still led to a situation where the client would be stuck trying to authenticate forever. Added a step prior to authentication where the client listens for a message with { instanceReady: true }, which is sent by setupSocketFunctions. If the server isn't ready within 10 seconds, then it returns { instanceReady: false }, and the client will do a new instanceserver provision and hopefully connect properly this time. * make eslint happy --------- Co-authored-by: Josh Field <[email protected]> * ignore hash when checking cache validity (#10900) * apply proper offsets to select (#10799) * apply proper offsets to select * add x offset calculation * fix offset in select * match tooltip with figma design (#10690) * match tooltip with figma design * fix check-errors * fix check errors * match title background with figma * fix check errors * fix check errors --------- Co-authored-by: Appaji <[email protected]> * center and elipse long text (#10895) * remove fixed height (#10899) Co-authored-by: Aditya Mitra <[email protected]> * replace studio assets pagination with infinite scroll (#10756) * set up observer api * add asset infinite scroll with observer api * clean up * fix categorie change * remove table pagination code * add infinite scroll in assets container * keep calling api till element is in view --------- Co-authored-by: aditya-mitra <[email protected]> * studio: swap lit unlit title (#10818) * swap lit unlit title * flip lit and unlit icon --------- Co-authored-by: Liam Broza <[email protected]> * studio: update asset tree to new design (#10817) * update aseet tree bg and padding * update h on desph * padding * some padding change * assset height cleanup * fix font size * fix tolbar * Restrict file name length to 64 characters (#10752) * restrct file name to 64 characters * bake length search into regex , remove unused regex * remove comments * ensure all models have loaded in the scene before marking scene as fully loaded (#10903) Co-authored-by: lonedevr <[email protected]> --------- Co-authored-by: Josh Field <[email protected]> Co-authored-by: Michael Estes <[email protected]> Co-authored-by: Daniel Belmes <[email protected]> Co-authored-by: lucas3900 <[email protected]> Co-authored-by: Kyle Baran <[email protected]> Co-authored-by: José Galván <[email protected]> Co-authored-by: Hanzla Mateen <[email protected]> Co-authored-by: Aditya Mitra <[email protected]> Co-authored-by: Appaji <[email protected]> Co-authored-by: Andy Chen <[email protected]> Co-authored-by: Liam Broza <[email protected]> Co-authored-by: Rahul Ghosh <[email protected]> Co-authored-by: lonedevr <[email protected]> --------- Co-authored-by: Josh Field <[email protected]> Co-authored-by: Michael Estes <[email protected]> Co-authored-by: Daniel Belmes <[email protected]> Co-authored-by: lucas3900 <[email protected]> Co-authored-by: Kyle Baran <[email protected]> Co-authored-by: José Galván <[email protected]> Co-authored-by: Hanzla Mateen <[email protected]> Co-authored-by: Aditya Mitra <[email protected]> Co-authored-by: Appaji <[email protected]> Co-authored-by: Andy Chen <[email protected]> Co-authored-by: Liam Broza <[email protected]> Co-authored-by: Rahul Ghosh <[email protected]> Co-authored-by: lonedevr <[email protected]>
dinomut1
added a commit
that referenced
this pull request
Aug 7, 2024
* Dev to Int (#10892) * Revert "Physics reactivity for collider component updates and order dependenc…" (#10876) This reverts commit 33afb3b. * fix collider reactivity (#10877) * fix collider reactivity * fix tests * optimize * fix duplicate new scene (#10880) * rigidbody initialization quick fix (#10883) * Upload drag drop files MT fix (#10881) * Upload drag drop files MT fix * Array length check * LerpTransform from rigid body uses rigid body instead of scene entity (#10882) * remove old workflows (#10886) * fix rigidbody crash server (#10891) --------- Co-authored-by: Josh Field <[email protected]> Co-authored-by: Michael Estes <[email protected]> Co-authored-by: Daniel Belmes <[email protected]> Co-authored-by: lucas3900 <[email protected]> * pushing dev to int (#10896) * Revert "Physics reactivity for collider component updates and order dependenc…" (#10876) This reverts commit 33afb3b. * fix collider reactivity (#10877) * fix collider reactivity * fix tests * optimize * fix duplicate new scene (#10880) * rigidbody initialization quick fix (#10883) * Upload drag drop files MT fix (#10881) * Upload drag drop files MT fix * Array length check * LerpTransform from rigid body uses rigid body instead of scene entity (#10882) * remove old workflows (#10886) * fix rigidbody crash server (#10891) * IR-3561: Magic Link template support for mobile and desktop (#10889) * feat: refactor magic link email template to support desktop and mobile chore: layout template to reuse styles in other templates * Fixed logo link --------- Co-authored-by: Hanzla Mateen <[email protected]> * Fixed bugs in instanceserver connections (#10887) * Fixed bugs in instanceserver connections There were still some bugs surrounding a client connecting to an instanceserver if the instance record for that server no longer existed. updateInstance needed to return false in that situation. This still led to a situation where the client would be stuck trying to authenticate forever. Added a step prior to authentication where the client listens for a message with { instanceReady: true }, which is sent by setupSocketFunctions. If the server isn't ready within 10 seconds, then it returns { instanceReady: false }, and the client will do a new instanceserver provision and hopefully connect properly this time. * make eslint happy --------- Co-authored-by: Josh Field <[email protected]> --------- Co-authored-by: Josh Field <[email protected]> Co-authored-by: Michael Estes <[email protected]> Co-authored-by: Daniel Belmes <[email protected]> Co-authored-by: lucas3900 <[email protected]> Co-authored-by: Kyle Baran <[email protected]> Co-authored-by: José Galván <[email protected]> Co-authored-by: Hanzla Mateen <[email protected]> * dev to int (#10901) (#10902) * Revert "Physics reactivity for collider component updates and order dependenc…" (#10876) This reverts commit 33afb3b. * fix collider reactivity (#10877) * fix collider reactivity * fix tests * optimize * fix duplicate new scene (#10880) * rigidbody initialization quick fix (#10883) * Upload drag drop files MT fix (#10881) * Upload drag drop files MT fix * Array length check * LerpTransform from rigid body uses rigid body instead of scene entity (#10882) * remove old workflows (#10886) * fix rigidbody crash server (#10891) * IR-3561: Magic Link template support for mobile and desktop (#10889) * feat: refactor magic link email template to support desktop and mobile chore: layout template to reuse styles in other templates * Fixed logo link --------- * Fixed bugs in instanceserver connections (#10887) * Fixed bugs in instanceserver connections There were still some bugs surrounding a client connecting to an instanceserver if the instance record for that server no longer existed. updateInstance needed to return false in that situation. This still led to a situation where the client would be stuck trying to authenticate forever. Added a step prior to authentication where the client listens for a message with { instanceReady: true }, which is sent by setupSocketFunctions. If the server isn't ready within 10 seconds, then it returns { instanceReady: false }, and the client will do a new instanceserver provision and hopefully connect properly this time. * make eslint happy --------- * ignore hash when checking cache validity (#10900) --------- Co-authored-by: Josh Field <[email protected]> Co-authored-by: Michael Estes <[email protected]> Co-authored-by: Daniel Belmes <[email protected]> Co-authored-by: lucas3900 <[email protected]> Co-authored-by: Kyle Baran <[email protected]> Co-authored-by: José Galván <[email protected]> Co-authored-by: Hanzla Mateen <[email protected]> * Int (#10911) * dev to int (#10901) * Revert "Physics reactivity for collider component updates and order dependenc…" (#10876) This reverts commit 33afb3b. * fix collider reactivity (#10877) * fix collider reactivity * fix tests * optimize * fix duplicate new scene (#10880) * rigidbody initialization quick fix (#10883) * Upload drag drop files MT fix (#10881) * Upload drag drop files MT fix * Array length check * LerpTransform from rigid body uses rigid body instead of scene entity (#10882) * remove old workflows (#10886) * fix rigidbody crash server (#10891) * IR-3561: Magic Link template support for mobile and desktop (#10889) * feat: refactor magic link email template to support desktop and mobile chore: layout template to reuse styles in other templates * Fixed logo link --------- Co-authored-by: Hanzla Mateen <[email protected]> * Fixed bugs in instanceserver connections (#10887) * Fixed bugs in instanceserver connections There were still some bugs surrounding a client connecting to an instanceserver if the instance record for that server no longer existed. updateInstance needed to return false in that situation. This still led to a situation where the client would be stuck trying to authenticate forever. Added a step prior to authentication where the client listens for a message with { instanceReady: true }, which is sent by setupSocketFunctions. If the server isn't ready within 10 seconds, then it returns { instanceReady: false }, and the client will do a new instanceserver provision and hopefully connect properly this time. * make eslint happy --------- Co-authored-by: Josh Field <[email protected]> * ignore hash when checking cache validity (#10900) --------- Co-authored-by: Josh Field <[email protected]> Co-authored-by: Michael Estes <[email protected]> Co-authored-by: Daniel Belmes <[email protected]> Co-authored-by: lucas3900 <[email protected]> Co-authored-by: Kyle Baran <[email protected]> Co-authored-by: José Galván <[email protected]> Co-authored-by: Hanzla Mateen <[email protected]> * dev to int: Fix scene loading (#10910) * Revert "Physics reactivity for collider component updates and order dependenc…" (#10876) This reverts commit 33afb3b. * fix collider reactivity (#10877) * fix collider reactivity * fix tests * optimize * fix duplicate new scene (#10880) * rigidbody initialization quick fix (#10883) * Upload drag drop files MT fix (#10881) * Upload drag drop files MT fix * Array length check * LerpTransform from rigid body uses rigid body instead of scene entity (#10882) * remove old workflows (#10886) * fix rigidbody crash server (#10891) * IR-3561: Magic Link template support for mobile and desktop (#10889) * feat: refactor magic link email template to support desktop and mobile chore: layout template to reuse styles in other templates * Fixed logo link --------- Co-authored-by: Hanzla Mateen <[email protected]> * Fixed bugs in instanceserver connections (#10887) * Fixed bugs in instanceserver connections There were still some bugs surrounding a client connecting to an instanceserver if the instance record for that server no longer existed. updateInstance needed to return false in that situation. This still led to a situation where the client would be stuck trying to authenticate forever. Added a step prior to authentication where the client listens for a message with { instanceReady: true }, which is sent by setupSocketFunctions. If the server isn't ready within 10 seconds, then it returns { instanceReady: false }, and the client will do a new instanceserver provision and hopefully connect properly this time. * make eslint happy --------- Co-authored-by: Josh Field <[email protected]> * ignore hash when checking cache validity (#10900) * apply proper offsets to select (#10799) * apply proper offsets to select * add x offset calculation * fix offset in select * match tooltip with figma design (#10690) * match tooltip with figma design * fix check-errors * fix check errors * match title background with figma * fix check errors * fix check errors --------- Co-authored-by: Appaji <[email protected]> * center and elipse long text (#10895) * remove fixed height (#10899) Co-authored-by: Aditya Mitra <[email protected]> * replace studio assets pagination with infinite scroll (#10756) * set up observer api * add asset infinite scroll with observer api * clean up * fix categorie change * remove table pagination code * add infinite scroll in assets container * keep calling api till element is in view --------- Co-authored-by: aditya-mitra <[email protected]> * studio: swap lit unlit title (#10818) * swap lit unlit title * flip lit and unlit icon --------- Co-authored-by: Liam Broza <[email protected]> * studio: update asset tree to new design (#10817) * update aseet tree bg and padding * update h on desph * padding * some padding change * assset height cleanup * fix font size * fix tolbar * Restrict file name length to 64 characters (#10752) * restrct file name to 64 characters * bake length search into regex , remove unused regex * remove comments * ensure all models have loaded in the scene before marking scene as fully loaded (#10903) Co-authored-by: lonedevr <[email protected]> --------- Co-authored-by: Josh Field <[email protected]> Co-authored-by: Michael Estes <[email protected]> Co-authored-by: Daniel Belmes <[email protected]> Co-authored-by: lucas3900 <[email protected]> Co-authored-by: Kyle Baran <[email protected]> Co-authored-by: José Galván <[email protected]> Co-authored-by: Hanzla Mateen <[email protected]> Co-authored-by: Aditya Mitra <[email protected]> Co-authored-by: Appaji <[email protected]> Co-authored-by: Andy Chen <[email protected]> Co-authored-by: Liam Broza <[email protected]> Co-authored-by: Rahul Ghosh <[email protected]> Co-authored-by: lonedevr <[email protected]> --------- Co-authored-by: Josh Field <[email protected]> Co-authored-by: Michael Estes <[email protected]> Co-authored-by: Daniel Belmes <[email protected]> Co-authored-by: lucas3900 <[email protected]> Co-authored-by: Kyle Baran <[email protected]> Co-authored-by: José Galván <[email protected]> Co-authored-by: Hanzla Mateen <[email protected]> Co-authored-by: Aditya Mitra <[email protected]> Co-authored-by: Appaji <[email protected]> Co-authored-by: Andy Chen <[email protected]> Co-authored-by: Liam Broza <[email protected]> Co-authored-by: Rahul Ghosh <[email protected]> Co-authored-by: lonedevr <[email protected]> --------- Co-authored-by: Kyle Baran <[email protected]> Co-authored-by: Josh Field <[email protected]> Co-authored-by: Michael Estes <[email protected]> Co-authored-by: Daniel Belmes <[email protected]> Co-authored-by: lucas3900 <[email protected]> Co-authored-by: José Galván <[email protected]> Co-authored-by: Hanzla Mateen <[email protected]> Co-authored-by: Aditya Mitra <[email protected]> Co-authored-by: Appaji <[email protected]> Co-authored-by: Andy Chen <[email protected]> Co-authored-by: Liam Broza <[email protected]> Co-authored-by: Rahul Ghosh <[email protected]> Co-authored-by: lonedevr <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.