Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/SOF-7433 feat: add grain boundary #161

Merged
merged 32 commits into from
Sep 28, 2024
Merged

feature/SOF-7433 feat: add grain boundary #161

merged 32 commits into from
Sep 28, 2024

Conversation

VsevolodX
Copy link
Member

  • feat: add gb configuration
  • feat: first implementation of slab grain boundary
  • chore: run lint fix

phase_2_configuration: SlabConfiguration
phase_1_termination: Termination
phase_2_termination: Termination
gap: float
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need units

from .configuration import GrainBoundaryConfiguration


def create_grain_boundary(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docstring

@VsevolodX VsevolodX marked this pull request as ready for review September 26, 2024 02:40
@VsevolodX VsevolodX merged commit 575ba87 into main Sep 28, 2024
9 checks passed
@VsevolodX VsevolodX deleted the feature/SOF-7433 branch September 28, 2024 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants