Remove parent/root from IC's and others #1038
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psakievich
requested review from
rcknaus,
alanw0,
jrood-nrel,
PaulMullowney and
neilmatula
psakievich
force-pushed
the
rf/parent-root
branch
from
1a2f8a7 to
7ada8ee
Compare
psakievich
changed the title
jrood-nrel
approved these changes
Sep 12, 2022
PaulMullowney
pushed a commit
to PaulMullowney/nalu-wind
that referenced
this pull request
Nov 29, 2022
* Remove parent/root from IC's * Delete some comments * Add unit tests * Remove unused functions from MaterialProperties * Remove from TimeIntegrator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuing the work of #997. Essentially a repeat of #1002 for IC's.