Create finite element assembly for Springs elements #323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddement
reviewed
Dec 19, 2024
tests/unit_tests/dof_management/test_assemble_node_freedom_allocation_table.cpp
Outdated
Show resolved
Hide resolved
…or terms assembly of Springs
…matrix terms of Springs
… values from state
… residual and stiffness matrix of Springs
…prings stiffness matrix assembly into the global sparse system matrix
ddement
reviewed
Dec 24, 2024
ddement
reviewed
Dec 24, 2024
ddement
reviewed
Dec 24, 2024
ddement
reviewed
Dec 24, 2024
ddement
reviewed
Dec 24, 2024
…Springs assembly + unroll outer loops
…sMatrixSprings functions
… failing with factorization error so commented out
|
@ddement I added unit tests for the residual and stiffness matrix assembly. While these look good, there is something wrong with the contribution to sparse matrix logic -- specifically this r-test is failing due to "KLU2 numeric factorization failed". Could you help with debugging this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Complements the work done in #321, i.e. completes the task description provided in springs element implementation. Specifically, finite element infrastructure was expanded to accommodate Springs elements creation and assembly in OpenTurbine.