-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix search invoice page doesn't display merchant text "expense" #53349
base: main
Are you sure you want to change the base?
Conversation
@ishpaul777 @MonilBhavsar One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Reviewer Checklist
Screenshots/VideosAndroid: NativeRecord_2024-12-04-23-25-58.mp4Android: mWeb ChromeRecord_2024-12-04-23-33-09.mp4iOS: NativeScreen.Recording.2024-12-04.at.11.16.16.PM.moviOS: mWeb SafariScreen.Recording.2024-12-04.at.11.13.49.PM.movMacOS: Chrome / SafariScreen.Recording.2024-12-04.at.11.45.30.PM.movMacOS: DesktopScreen.Recording.2024-12-04.at.11.43.07.PM.mov |
@NJ-2020 Can you please add unit tests? https://expensify.slack.com/archives/C01GTK53T8Q/p1733148961659549 |
@ishpaul777 I think we should include unit tests in new issues(new proposal template) in the proposal based on this |
Yes, would be good to add unit tests |
I agree. Let's add some tests. |
Creating unit test Is there any utils function to generate fake search data results? cc: @luacmartins |
@NJ-2020 not yet, but you could probably copy/paste a result you get locally. |
Hi, I am very sorry. Thanks cc: @ishpaul777 |
Sorry to hear that. Sending condolences. Please take your time. |
So sorry to hear that @NJ-2020. Take your time. |
I am so sorry to hear about your loss. Please accept my deepest condolences to you and your family during this difficult time. Take all the time you need @NJ-2020 |
Sorry for the delay Done, I've created the unit test file Please re-review Also I see another bug while creating the unit test file, the |
@NJ-2020 Please fix eslint check failing, should be straightforward |
Done cc: @MonilBhavsar |
Explanation of Change
Fixed Issues
$ #50794
PROPOSAL: #50794 (comment)
Tests
Same as QA
Offline tests
Same as QA
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Screen.Recording.2024-12-03.at.15.24.09.mov
Android: mWeb Chrome
Screen.Recording.2024-12-04.at.07.11.06.mov
iOS: Native
Screen.Recording.2024-12-04.at.08.46.30.mov
iOS: mWeb Safari
Screen.Recording.2024-12-04.at.08.09.13.mov
MacOS: Chrome / Safari
Screen.Recording.2024-12-04.at.09.08.12.mov
MacOS: Desktop
Screen.Recording.2024-12-04.at.08.55.09.mov