fix: Navigation bar shows purple color in offline mode #53686

nkdengineer · 2024-12-06T09:05:25Z

Explanation of Change

Fixed Issues

$ #53444
PROPOSAL: #53444 (comment)

Tests

Precondition: device uses button navigation, not gesture navigation

Go offline.
Open FAB > Submit expense.
Enter amount > Next.
Tap "Submit an expense, get $250" banner.
Verify that: The device navigation bar will not have purple color.

Verify that no errors appear in the JS console

Offline tests

same as above

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."
same as above

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

melvin-bot · 2024-12-09T08:13:23Z

@dominictb Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

dominictb · 2024-12-12T20:52:05Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

dominictb · 2024-12-12T21:06:11Z

src/components/ScreenWrapper.tsx

+                                            containerStyles={
+                                                includeSafeAreaPaddingBottom
+                                                    ? []
+                                                    : [styles.offlineIndicatorMobile, {paddingBottom: paddingBottom + styles.offlineIndicatorMobile.paddingBottom}]


Why don't you use the unmodifiedPaddings or safeAreaPaddingBottomStyle?

The reason is the default style of OfflineIndicator has a padding style in offlineIndicatorMobile and we need more padding-bottom when includeSafeAreaPaddingBottom is false.

App/src/components/OfflineIndicator.tsx

Lines 29 to 36 in 653af04

const computedStyles = useMemo((): StyleProp<ViewStyle> => {

if (containerStyles) {

return containerStyles;

}

return shouldUseNarrowLayout ? styles.offlineIndicatorMobile : styles.offlineIndicator;

}, [containerStyles, shouldUseNarrowLayout, styles.offlineIndicatorMobile, styles.offlineIndicator]);

@dominictb friendly bump

dominictb · 2024-12-23T10:35:03Z

@nkdengineer BUG: Offline indicator is overlap by device edge:

nkdengineer · 2024-12-24T06:55:25Z

@dominictb i fixed

dominictb

LGTM 🎀👀🎀

dominictb · 2024-12-24T08:01:24Z

@nkdengineer One last thing. Please update the test precondition to be "Device uses button navigation, not gesture navigation".

nkdengineer · 2024-12-25T03:52:01Z

@dominictb i udpated

dominictb · 2024-12-26T06:15:01Z

@MarioExpensify Pending your review.

MarioExpensify

LGTM!

OSBotify · 2024-12-26T14:19:39Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2024-12-26T20:54:40Z

🚀 Deployed to staging by https://github.com/MarioExpensify in version: 9.0.79-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

izarutskaya · 2024-12-27T09:58:00Z

@nkdengineer This PR is failing with #54602

https://platform.applause.com/services/links/v1/external/ae551e10676ec93178e9a0c027a78bfdd54372d9888b9a9afe17f96df8fecef3

nkdengineer added 3 commits December 6, 2024 16:04

fix: Navigation bar shows purple color in offline mode

de76e7e

fix typecheck

b545bac

Merge branch 'main' into fix/53444

e6cce93

nkdengineer marked this pull request as ready for review December 9, 2024 08:13

nkdengineer requested a review from a team as a code owner December 9, 2024 08:13

melvin-bot bot requested review from dominictb and removed request for a team December 9, 2024 08:13

dominictb reviewed Dec 12, 2024

View reviewed changes

nkdengineer added 2 commits December 19, 2024 16:42

resolve conflict

b8a295d

Merge branch 'main' into fix/53444

836a856

fix style offline indicattor

8286cc3

dominictb approved these changes Dec 24, 2024

View reviewed changes

melvin-bot bot requested a review from MarioExpensify December 24, 2024 07:59

MarioExpensify approved these changes Dec 26, 2024

View reviewed changes

MarioExpensify merged commit 499b61b into Expensify:main Dec 26, 2024
18 checks passed

github-actions bot mentioned this pull request Dec 26, 2024

Deploy Checklist: New Expensify 2024-12-26 #54591

Open

33 tasks

mitarachim mentioned this pull request Dec 27, 2024

mWeb - When tapping back, the header on mWeb stays purple for a couple of seconds #54602

Open

8 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Navigation bar shows purple color in offline mode #53686

fix: Navigation bar shows purple color in offline mode #53686

nkdengineer commented Dec 6, 2024 •

edited

Loading

melvin-bot bot commented Dec 9, 2024

dominictb commented Dec 12, 2024 •

edited

Loading

dominictb Dec 12, 2024

nkdengineer Dec 16, 2024

nkdengineer Dec 19, 2024

dominictb commented Dec 23, 2024

nkdengineer commented Dec 24, 2024

dominictb left a comment

dominictb commented Dec 24, 2024 •

edited

Loading

nkdengineer commented Dec 25, 2024

dominictb commented Dec 26, 2024

MarioExpensify left a comment

OSBotify commented Dec 26, 2024

github-actions bot commented Dec 26, 2024

izarutskaya commented Dec 27, 2024

	const computedStyles = useMemo((): StyleProp<ViewStyle> => {
	if (containerStyles) {
	return containerStyles;
	}

	return shouldUseNarrowLayout ? styles.offlineIndicatorMobile : styles.offlineIndicator;
	}, [containerStyles, shouldUseNarrowLayout, styles.offlineIndicatorMobile, styles.offlineIndicator]);

fix: Navigation bar shows purple color in offline mode #53686

fix: Navigation bar shows purple color in offline mode #53686

Conversation

nkdengineer commented Dec 6, 2024 • edited Loading

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Dec 9, 2024

dominictb commented Dec 12, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

dominictb Dec 12, 2024

Choose a reason for hiding this comment

nkdengineer Dec 16, 2024

Choose a reason for hiding this comment

nkdengineer Dec 19, 2024

Choose a reason for hiding this comment

dominictb commented Dec 23, 2024

nkdengineer commented Dec 24, 2024

dominictb left a comment

Choose a reason for hiding this comment

dominictb commented Dec 24, 2024 • edited Loading

nkdengineer commented Dec 25, 2024

dominictb commented Dec 26, 2024

MarioExpensify left a comment

Choose a reason for hiding this comment

OSBotify commented Dec 26, 2024

github-actions bot commented Dec 26, 2024

izarutskaya commented Dec 27, 2024

nkdengineer commented Dec 6, 2024 •

edited

Loading

dominictb commented Dec 12, 2024 •

edited

Loading

dominictb commented Dec 24, 2024 •

edited

Loading