feat: Provide education/confirmation before creating workspaces in New Workspace flows #53845

Krishna2323 · 2024-12-10T12:24:21Z

Explanation of Change

Problem: When users attempting to submit expenses are inadvertently led to create workspaces, it causes confusion about how to submit an expense to their boss, leading to frustration and a poor user experience.
This PR adds a workspace confirmation page which will be shown before a workspace is created. Workspace confirmation page will have avatar picker, name input and currency selector, users can now choose custom avatar, workspace name and currency before creating a workspace.
This PR also fixes regressions from the previous PR. Issues:
$ [HOLD for payment 2024-12-19] [HOLD for payment 2024-12-17] Workspace - Unable to save new workspace name #53765
$ [HOLD for payment 2024-12-19] [HOLD for payment 2024-12-17] Create workspace - Selected currecy does not appear selected with a green checkmark #53766
$ [HOLD for payment 2024-12-19] [HOLD for payment 2024-12-17] Create workspace - Edit avatar modal is blocking the avatar #53768
$ [HOLD for payment 2024-12-19] [HOLD for payment 2024-12-17] Create workspace - Error message does not have left and right padding #53771
$ [HOLD for payment 2024-12-19] [HOLD for payment 2024-12-17] FAB - Page crashes after tracking an expense from QAB #53793

Fixed Issues

$ #51504
PROPOSAL: #51504 (comment)

Tests

Go to workspace lists page > Click on Create workspace
Verify RHP is opened with avatar selector, name input and currency selector.
Select any avatar > Enter custom name > Select a different currency
Click confirm
Verify workspace is created with the selected avatar, name and currency.
Repeat Step 1 to 4 with default avatar
Verify workspace is created with the default avatar, name and currency.
Repeat Step 1 to 4 with default currency
Verify workspace is created with the selected avatar, name and default currency.
Click on Create workspace > Enter any custom name
Verify default avatar uses the first character of the name.
Log out and login with a new account > Complete onboarding
Open FAB > Select New workspace > Verify RHP is opened with avatar selector, name input and currency selector.
Select any avatar > Enter custom name > Select a different currency
Click confirm
Verify workspace is created with the selected avatar, name and currency.
Delete the single workspace from workspace list page
On workspace list page click New Workspace button
Verify RHP is opened with avatar selector, name input and currency selector.
Select any avatar > Enter custom name > Select a different currency
Click confirm
Verify workspace is created with the selected avatar, name and currency.

Verify that no errors appear in the JS console

Offline tests

Go to workspace lists page > Click on Create workspace
Verify RHP is opened with avatar selector, name input and currency selector.
Select any avatar > Enter custom name > Select a different currency
Click confirm
Verify workspace is created with the selected avatar, name and currency.
Repeat Step 1 to 4 with default avatar
Verify workspace is created with the default avatar, name and currency.
Repeat Step 1 to 4 with default currency
Verify workspace is created with the selected avatar, name and default currency.
Click on Create workspace > Enter any custom name
Verify default avatar uses the first character of the name.
Log out and login with a new account > Complete onboarding
Open FAB > Select New workspace > Verify RHP is opened with avatar selector, name input and currency selector.
Select any avatar > Enter custom name > Select a different currency
Click confirm
Verify workspace is created with the selected avatar, name and currency.
Delete the single workspace from workspace list page
On workspace list page click New Workspace button
Verify RHP is opened with avatar selector, name input and currency selector.
Select any avatar > Enter custom name > Select a different currency
Click confirm
Verify workspace is created with the selected avatar, name and currency.

QA Steps

Go to workspace lists page > Click on Create workspace
Verify RHP is opened with avatar selector, name input and currency selector.
Select any avatar > Enter custom name > Select a different currency
Click confirm
Verify workspace is created with the selected avatar, name and currency.
Repeat Step 1 to 4 with default avatar
Verify workspace is created with the default avatar, name and currency.
Repeat Step 1 to 4 with default currency
Verify workspace is created with the selected avatar, name and default currency.
Click on Create workspace > Enter any custom name
Verify default avatar uses the first character of the name.
Log out and login with a new account > Complete onboarding
Open FAB > Select New workspace > Verify RHP is opened with avatar selector, name input and currency selector.
Select any avatar > Enter custom name > Select a different currency
Click confirm
Verify workspace is created with the selected avatar, name and currency.
Delete the single workspace from workspace list page
On workspace list page click New Workspace button
Verify RHP is opened with avatar selector, name input and currency selector.
Select any avatar > Enter custom name > Select a different currency
Click confirm
Verify workspace is created with the selected avatar, name and currency.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android_native.mp4

Android: mWeb Chrome

android_chrome.mp4

iOS: Native

ios_native.mp4

iOS: mWeb Safari

ios_safari.mp4

MacOS: Chrome / Safari

web_chrome.mp4

MacOS: Desktop

desktop_app.mp4

…space flows. Signed-off-by: krishna2323 <[email protected]>

Signed-off-by: krishna2323 <[email protected]>

Krishna2323 · 2024-12-11T08:31:05Z

@allgandalf, the regression issues are fixed but I'm facing a new error, can you please take a look?

Monosnap.screencast.2024-12-11.13-55-01.mp4

allgandalf · 2024-12-12T09:06:19Z

Can you merge main and retry ? is this constantly reproducible ?

Krishna2323 · 2024-12-14T10:12:26Z

I'm still able to reproduce this issue even after merging main. I'm investigating the RCA of the issue. @allgandalf please let me know if you know anything about this, this is probably related to how we are updating the onyx value.

It only occurs when creating a second workspace with an avatar. I'm unsure if this is a backend or frontend bug.

allgandalf · 2024-12-14T16:29:44Z

Can you put out reproduction steps please

Krishna2323 · 2024-12-15T02:44:23Z

Reproduction Steps:

Create a new account > Manage my team's expenses during onboarding process
Go to workspace list page > Create a workspace with an avatar

danielrvidal · 2024-12-18T17:42:12Z

I can also reproduce the issue. You can see it here:
https://github.com/user-attachments/assets/9f2267d5-72c8-4c98-899e-189183126c0b

shubham1206agra · 2024-12-19T05:57:29Z

src/libs/actions/Policy/Policy.ts

@@ -1891,6 +1910,8 @@ function buildPolicyData(policyOwnerEmail = '', makeMeAdmin = false, policyName
        customUnitID,
        customUnitRateID,
        engagementChoice,
+        currency: outputCurrency,
+        file,


Suggested change

file,

file: {...file},

Please soft clone it to remove non-indexable errors.

shubham1206agra · 2024-12-19T05:58:15Z

src/libs/actions/Policy/Policy.ts

@@ -2007,6 +2038,8 @@ function createDraftWorkspace(policyOwnerEmail = '', makeMeAdmin = false, policy
        expenseCreatedReportActionID,
        customUnitID,
        customUnitRateID,
+        currency: outputCurrency,
+        file,


Suggested change

file,

file: {...file},

Please soft clone it to remove non-indexable errors.

Thanks @shubham1206agra 🙇🏻, checking...

shubham1206agra · 2024-12-19T06:00:14Z

@Krishna2323 Can you ready this PR with fixes?

I need this PR merged today. So, I can work on another feature which requires this screen.

shubham1206agra · 2024-12-19T06:07:15Z

src/languages/en.ts

@@ -3723,7 +3723,7 @@ const translations = {
        },
        emptyWorkspace: {
            title: 'Create a workspace',
-            subtitle: 'Create a workspace to track receipts, reimburse expenses, send invoices, and more -- all at the speed of chat.',
+            subtitle: 'Create a workspace to track receipts, reimburse expenses, send invoices, and more — all at the speed of chat.',


Suggested change

subtitle: 'Create a workspace to track receipts, reimburse expenses, send invoices, and more — all at the speed of chat.',

subtitle: 'Create a workspace to track receipts, reimburse expenses, manage travel, send invoices, and more — all at the speed of chat.',

Update the copy as per #53753 (comment)

I think this update can be made in this PR.

Alright, thanks

Signed-off-by: krishna2323 <[email protected]>

Krishna2323 · 2024-12-19T12:17:38Z

@allgandalf, you can review the code, I will add the screenshot after few hours.

allgandalf · 2024-12-19T14:37:10Z

all good, please take a look at the failing test as well

Krishna2323 · 2024-12-20T10:34:46Z

Not sure why the BE is not returning the correct avatar. Will check again.

Signed-off-by: krishna2323 <[email protected]>

github-actions · 2024-12-20T16:24:48Z

🚧 @shawnborton has triggered a test build. You can view the workflow run here.

allgandalf · 2024-12-20T16:27:05Z

@Krishna2323 please fix eslint

Signed-off-by: krishna2323 <[email protected]>

Krishna2323 · 2024-12-20T17:09:45Z

@allgandalf lint issues fixed.

allgandalf · 2024-12-23T05:30:46Z

@Krishna2323 can you please merge main? the iOS build is failing on current branch, we fixed iOS build with latest commits on main

allgandalf · 2024-12-23T05:31:04Z

I will complete other platform testing in the meantime

allgandalf · 2024-12-24T06:42:28Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

allgandalf · 2024-12-24T06:42:38Z

@Krishna2323 can you please update native platform videos

Signed-off-by: krishna2323 <[email protected]>

Krishna2323 · 2024-12-24T12:42:00Z

native platform videos uploaded, was facing build issues last time.

allgandalf · 2024-12-24T12:55:16Z

Asked for a new ad-hoc build

shawnborton · 2024-12-24T15:25:32Z

I can kick it off 🚀

github-actions · 2024-12-24T15:26:11Z

🚧 @shawnborton has triggered a test build. You can view the workflow run here.

github-actions · 2024-12-24T15:50:12Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/53845/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/53845/index.html

Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/53845/NewExpensify.dmg	https://53845.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

allgandalf · 2024-12-24T17:19:57Z

Bug: Not found page when workspace is created from the onboarding modal:

Open the adhoc link in incognito mode ( i am able to reproduce this constantly in incognito mode / first time i tried this build)

Screen.Recording.2024-12-24.at.10.48.13.PM.mov

allgandalf · 2024-12-24T17:22:42Z

Bug: The central pane changes on refresh

( we discussed this solution on the other PR please implement that)

Screen.Recording.2024-12-24.at.10.52.01.PM.mov

allgandalf · 2024-12-24T17:26:48Z

Bug: Console error when you create a workspace with attachment in offline mode:

allgandalf

I will do a review again tomorrow morning, I guess there isn't much left to change, looks good overall

src/libs/fileDownload/FileUtils.ts

src/components/CurrencyPicker.tsx

allgandalf · 2024-12-24T17:32:49Z

src/languages/en.ts

@@ -3723,7 +3723,7 @@ const translations = {
        },
        emptyWorkspace: {
            title: 'Create a workspace',
-            subtitle: 'Create a workspace to track receipts, reimburse expenses, send invoices, and more -- all at the speed of chat.',
+            subtitle: 'Create a workspace to track receipts, reimburse expenses, send invoices, and more — all at the speed of chat.',


Alright, thanks

src/libs/actions/Policy/Policy.ts

Krishna2323 · 2024-12-26T13:22:47Z

Not found page when workspace is created from the onboarding modal:

@allgandalf, this isn't related to our PR, it can also be reproduced using this adhoc build.

Signed-off-by: krishna2323 <[email protected]>

shubham1206agra · 2024-12-26T15:35:32Z

src/libs/fileDownload/FileUtils.ts

+const createFile = (file: File): FileObject => {
+    if (getPlatform() === 'web') {
+        return new File([file], file.name, {
+            type: file.type,
+            lastModified: file.lastModified,
+        });
+    }
+    return {
+        uri: file.uri,
+        name: file.name,
+        type: file.type,
+    };
+};


@Krishna2323 Can you tell us why did you create this method here?

The File API is part of the web platform and is not supported on native iOS and Android environments. This function ensures compatibility by creating a platform-specific file object, handling both web and native platforms appropriately.

Signed-off-by: krishna2323 <[email protected]>

Krishna2323 · 2024-12-26T22:46:41Z

Bug: Console error when you create a workspace with attachment in offline mode:

I can't reproduce this bug.

Monosnap.screencast.2024-12-27.04-11-44.mp4

Krishna2323 added 3 commits December 10, 2024 15:59

Provide education/confirmation before creating workspaces in New Work…

7f40593

…space flows. Signed-off-by: krishna2323 <[email protected]>

Provide education/confirmation before creating workspaces in New Work…

ee98ccd

…space flows. Signed-off-by: krishna2323 <[email protected]>

Merge branch 'Expensify:main' into krishna2323/issue/52164_pr2

3b47bb6

Krishna2323 changed the title ~~Krishna2323/issue/52164 pr2~~ feat: Provide education/confirmation before creating workspaces in New Workspace flows Dec 10, 2024

Krishna2323 added 4 commits December 11, 2024 10:11

fix: Selected currecy does not appear selected with a green checkmark.

0125372

Signed-off-by: krishna2323 <[email protected]>

fix: Create workspace - Edit avatar modal is blocking the avatar.

50a5a5d

Signed-off-by: krishna2323 <[email protected]>

fix: Error message does not have left and right padding.

1863105

Signed-off-by: krishna2323 <[email protected]>

add param names.

3748621

Signed-off-by: krishna2323 <[email protected]>

Krishna2323 added 2 commits December 13, 2024 08:00

Merge branch 'Expensify:main' into krishna2323/issue/52164_pr2

59713aa

Merge branch 'Expensify:main' into krishna2323/issue/52164_pr2

88960da

shubham1206agra reviewed Dec 19, 2024

View reviewed changes

shubham1206agra mentioned this pull request Dec 19, 2024

[HOLD #53845]Implement upgrade to control when booking travel #53753

Draft

50 tasks

shubham1206agra reviewed Dec 19, 2024

View reviewed changes

shubham1206agra mentioned this pull request Dec 19, 2024

[hold for #53845][$250] Book Travel - Unable to continue setting up travel, error appears #48305

Open

6 tasks

Krishna2323 added 2 commits December 19, 2024 17:18

Merge branch 'Expensify:main' into krishna2323/issue/52164_pr2

113f37b

crash fix.

1757ec8

Signed-off-by: krishna2323 <[email protected]>

Merge branch 'main' into krishna2323/issue/52164_pr2

f08311b

fix: file not cloned correctly.

29dbf37

Signed-off-by: krishna2323 <[email protected]>

Krishna2323 marked this pull request as ready for review December 20, 2024 16:12

Krishna2323 added 2 commits December 20, 2024 22:04

fix eslint.

ec414be

Signed-off-by: krishna2323 <[email protected]>

fix eslint.

60529a7

Signed-off-by: krishna2323 <[email protected]>

This comment has been minimized.

Sign in to view

minor fix.

85bfaaf

Signed-off-by: krishna2323 <[email protected]>

Merge branch 'Expensify:main' into krishna2323/issue/52164_pr2

d9b1f64

Krishna2323 added 2 commits December 24, 2024 17:28

Merge branch 'Expensify:main' into krishna2323/issue/52164_pr2

4aba5aa

fix file upload on native platforms.

a7ccb88

Signed-off-by: krishna2323 <[email protected]>

allgandalf suggested changes Dec 24, 2024

View reviewed changes

Merge branch 'Expensify:main' into krishna2323/issue/52164_pr2

0e3cdef

Krishna2323 added 2 commits December 26, 2024 18:54

add backTo param in WORKSPACE_CONFIRMATION page.

21a213c

Signed-off-by: krishna2323 <[email protected]>

minor fix.

a322dc8

Signed-off-by: krishna2323 <[email protected]>

shubham1206agra reviewed Dec 26, 2024

View reviewed changes

add comments.

4819755

Signed-off-by: krishna2323 <[email protected]>

	subtitle: 'Create a workspace to track receipts, reimburse expenses, send invoices, and more — all at the speed of chat.',
	subtitle: 'Create a workspace to track receipts, reimburse expenses, manage travel, send invoices, and more — all at the speed of chat.',

feat: Provide education/confirmation before creating workspaces in New Workspace flows #53845

Are you sure you want to change the base?

feat: Provide education/confirmation before creating workspaces in New Workspace flows #53845

Conversation

Krishna2323 commented Dec 10, 2024 • edited Loading

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Krishna2323 commented Dec 11, 2024

allgandalf commented Dec 12, 2024

Krishna2323 commented Dec 14, 2024

allgandalf commented Dec 14, 2024

Krishna2323 commented Dec 15, 2024 • edited Loading

danielrvidal commented Dec 18, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

shubham1206agra commented Dec 19, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Krishna2323 commented Dec 19, 2024

allgandalf commented Dec 19, 2024

Krishna2323 commented Dec 20, 2024

github-actions bot commented Dec 20, 2024

allgandalf commented Dec 20, 2024

This comment has been minimized.

Krishna2323 commented Dec 20, 2024

allgandalf commented Dec 23, 2024

allgandalf commented Dec 23, 2024

allgandalf commented Dec 24, 2024

Reviewer Checklist

Screenshots/Videos

allgandalf commented Dec 24, 2024

Krishna2323 commented Dec 24, 2024

allgandalf commented Dec 24, 2024

shawnborton commented Dec 24, 2024

github-actions bot commented Dec 24, 2024

github-actions bot commented Dec 24, 2024

allgandalf commented Dec 24, 2024

allgandalf commented Dec 24, 2024

allgandalf commented Dec 24, 2024

allgandalf left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Krishna2323 commented Dec 26, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Krishna2323 commented Dec 26, 2024

Krishna2323 commented Dec 10, 2024 •

edited

Loading

Krishna2323 commented Dec 15, 2024 •

edited

Loading