Feature: Add spinning loader until full list of policies is successfully download on the client #54238

twilight2294 · 2024-12-17T09:25:22Z

Explanation of Change

Fixed Issues

$ #52766
PROPOSAL: #52766 (comment)

Tests

Test 1:

Precondition: Be on 3G / Slow internet

Go to Troubleshoot page in settings > Click "Clear cache and restart"
Go to Workspaces

Verify that: you will see a loading spinner before seeing the workspace list page / empty workspace screen

Test 2:

Precondition: Be on 3G / Slow internet

Go to Troubleshoot page in settings > Click "Clear cache and restart"
Go to Workspace switcher LHP

Verify that: you will see a loading spinner before seeing the workspace list page / create workspace screen

Verify that no errors appear in the JS console

Offline tests

Test 1:

Go to Troubleshoot page in settings > Click "Clear cache and restart"
Go to Workspaces

Verify that: you will not see a loading spinner before seeing the workspace list page / empty workspace screen

Test 2:

Precondition: Be on 3G / Slow internet

Go to Troubleshoot page in settings > Click "Clear cache and restart"
Go to Workspace switcher LHP

Verify that: you will not see a loading spinner before seeing the workspace list page / create workspace screen

QA Steps

Test 1:

Precondition: Be on 3G / Slow internet

(Note that this will not be reproducible on fast internet)

Go to Troubleshoot page in settings > Click "Clear cache and restart"
Go to Workspaces

Verify that: you will see a loading spinner before seeing the workspace list page / empty workspace screen

Test 2:

Precondition: Be on 3G / Slow internet

Go to Troubleshoot page in settings > Click "Clear cache and restart"
Go to Workspace switcher LHP

Verify that: you will see a loading spinner before seeing the workspace list page / create workspace screen

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen_recording_20241223_122217.mp4

Android: mWeb Chrome

Screen_recording_20241223_122534.mp4

iOS: Native

Simulator.Screen.Recording.-.Expensify.testing.-.2024-12-23.at.12.14.39.mp4

iOS: mWeb Safari

Simulator.Screen.Recording.-.Expensify.testing.-.2024-12-23.at.12.16.37.mp4

MacOS: Chrome / Safari

Screen.Recording.2024-12-23.at.12.00.53.PM.mov

MacOS: Desktop

Screen.Recording.2024-12-23.at.12.04.03.PM.mov

melvin-bot · 2024-12-17T09:25:28Z

@parasharrajat Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

parasharrajat · 2024-12-19T18:59:09Z

@twilight2294 Can you please raise the Eslint warnings on Slack and see how can we solve it? What should be used as default for these?

parasharrajat · 2024-12-20T12:00:27Z

@twilight2294 Can you please merge main?

twilight2294 · 2024-12-20T12:01:43Z

sure, i will also update the videos today, had problem with my machine for past 2 days

parasharrajat · 2024-12-20T12:03:17Z

@twilight2294 Can you please raise the Eslint warnings on Slack and see how can we solve it? What should be used as default for these?

Don't forget to ask this. whether it should be CONST.DEFAULT_NUMBER_ID or something else? I am not sure about this too...

parasharrajat · 2024-12-20T12:03:38Z

Add QA steps and tests.

parasharrajat · 2024-12-20T20:52:03Z

@twilight2294 Please merge main again. There are issues on ios Build.

parasharrajat · 2024-12-21T09:57:24Z

@twilight2294 Could you please update the vids, test steps, and merge main? I also noticed that your signed commits do not show the username (Something to check).

twilight2294 · 2024-12-23T06:00:11Z

I also noticed that your signed commits do not show the username (Something to check).

So strange, I will take a look at this, thanks for checking

Signed-off-by: GitHub <[email protected]>

twilight2294 · 2024-12-23T06:10:46Z

Don't forget to ask this. whether it should be CONST.DEFAULT_NUMBER_ID or something else? I am not sure about this too...

Sorry @parasharrajat I am yet to be added to the slack, I have filled the google form but the invites are not available currently .

I read the docs attached with the error and tried fixing the errors, I updated everything according to the docs:

twilight2294 · 2024-12-23T06:53:43Z

@parasharrajat updated the videos and added testing steps, can you please review this again, thanks a lot

parasharrajat · 2024-12-23T08:42:35Z

src/libs/API/parameters/LeavePolicyParams.ts

@@ -1,5 +1,5 @@
 type LeavePolicyParams = {
-    policyID: string;
+    policyID?: string;


Let's not change the type.

parasharrajat · 2024-12-23T08:42:49Z

src/libs/ReportUtils.ts

@@ -7381,7 +7381,7 @@ function getWorkspaceChats(policyID: string, accountIDs: number[], reports: Onyx
 *
 * @param policyID - the workspace ID to get all associated reports
 */
-function getAllWorkspaceReports(policyID: string): Array<OnyxEntry<Report>> {
+function getAllWorkspaceReports(policyID: string | undefined): Array<OnyxEntry<Report>> {


We can remove this.

parasharrajat · 2024-12-23T08:43:08Z

src/libs/actions/Policy/Policy.ts

@@ -725,7 +725,7 @@ function clearWorkspaceReimbursementErrors(policyID: string) {
    Onyx.merge(`${ONYXKEYS.COLLECTION.POLICY}${policyID}`, {errorFields: {reimbursementChoice: null}});
 }

-function leaveWorkspace(policyID: string) {
+function leaveWorkspace(policyID: string | undefined) {


Let's early return here when policyid is undefined

parasharrajat · 2024-12-23T17:58:14Z

@twilight2294 Can you please fix the conflicts and make the requested changes?

Signed-off-by: GitHub <[email protected]>

twilight2294 · 2024-12-23T18:18:13Z

@parasharrajat can you please review again

parasharrajat · 2024-12-24T10:51:04Z

Screenshots

🔲 iOS / native

24.12.2024_16.32.52_REC.mp4

🔲 iOS / Safari

20.12.2024_18.33.43_REC.mp4

🔲 MacOS / Desktop

20.12.2024_18.03.16_REC.mp4

🔲 MacOS / Chrome

20.12.2024_17.59.21_REC.mp4

🔲 Android / Chrome

20.12.2024_18.29.59_REC.mp4

🔲 Android / native

21.12.2024_01.39.37_REC.mp4

parasharrajat

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

🎀 👀 🎀 C+ reviewed

twilight2294 added 2 commits December 17, 2024 14:52

show loading indicator when IS_LOADING_APP is true

76062d9

show loading indicator when IS_LOADING_APP is true

7084fbd

twilight2294 requested a review from a team as a code owner December 17, 2024 09:25

melvin-bot bot requested review from parasharrajat and removed request for a team December 17, 2024 09:25

twilight2294 added 2 commits December 18, 2024 11:55

Merge branch 'Expensify:main' into patch-19

3bff973

Merge branch 'Expensify:main' into patch-19

52b137f

Merge branch 'Expensify:main' into patch-19

ecaf750

Merge branch 'Expensify:main' into patch-19

ee69010

fix eslint

0d70cbf

Signed-off-by: GitHub <[email protected]>

parasharrajat suggested changes Dec 23, 2024

View reviewed changes

twilight2294 added 3 commits December 23, 2024 18:06

revert esLint fixes

7cf7728

Signed-off-by: GitHub <[email protected]>

Merge branch 'Expensify:main' into patch-19

bfac51d

Update ReportUtils.ts

20c1550

parasharrajat approved these changes Dec 24, 2024

View reviewed changes

melvin-bot bot requested a review from tgolen December 24, 2024 11:04

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature: Add spinning loader until full list of policies is successfully download on the client #54238

Feature: Add spinning loader until full list of policies is successfully download on the client #54238

twilight2294 commented Dec 17, 2024 •

edited

Loading

melvin-bot bot commented Dec 17, 2024

parasharrajat commented Dec 19, 2024

parasharrajat commented Dec 20, 2024

twilight2294 commented Dec 20, 2024

parasharrajat commented Dec 20, 2024

parasharrajat commented Dec 20, 2024

parasharrajat commented Dec 20, 2024

parasharrajat commented Dec 21, 2024

twilight2294 commented Dec 23, 2024

twilight2294 commented Dec 23, 2024 •

edited

Loading

twilight2294 commented Dec 23, 2024

parasharrajat Dec 23, 2024

parasharrajat Dec 23, 2024

parasharrajat Dec 23, 2024

twilight2294 Dec 23, 2024

parasharrajat commented Dec 23, 2024

twilight2294 commented Dec 23, 2024

parasharrajat commented Dec 24, 2024 •

edited

Loading

parasharrajat left a comment

Feature: Add spinning loader until full list of policies is successfully download on the client #54238

Are you sure you want to change the base?

Feature: Add spinning loader until full list of policies is successfully download on the client #54238

Conversation

twilight2294 commented Dec 17, 2024 • edited Loading

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Dec 17, 2024

parasharrajat commented Dec 19, 2024

parasharrajat commented Dec 20, 2024

twilight2294 commented Dec 20, 2024

parasharrajat commented Dec 20, 2024

parasharrajat commented Dec 20, 2024

parasharrajat commented Dec 20, 2024

parasharrajat commented Dec 21, 2024

twilight2294 commented Dec 23, 2024

twilight2294 commented Dec 23, 2024 • edited Loading

twilight2294 commented Dec 23, 2024

parasharrajat Dec 23, 2024

Choose a reason for hiding this comment

parasharrajat Dec 23, 2024

Choose a reason for hiding this comment

parasharrajat Dec 23, 2024

Choose a reason for hiding this comment

twilight2294 Dec 23, 2024

Choose a reason for hiding this comment

parasharrajat commented Dec 23, 2024

twilight2294 commented Dec 23, 2024

parasharrajat commented Dec 24, 2024 • edited Loading

Screenshots

🔲 iOS / native

🔲 iOS / Safari

🔲 MacOS / Desktop

🔲 MacOS / Chrome

🔲 Android / Chrome

🔲 Android / native

parasharrajat left a comment

Choose a reason for hiding this comment

Reviewer Checklist

twilight2294 commented Dec 17, 2024 •

edited

Loading

twilight2294 commented Dec 23, 2024 •

edited

Loading

parasharrajat commented Dec 24, 2024 •

edited

Loading