Add toggle for enable/disable instead of label #54451
Open
+169
−45
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Fixed Issues
$ #53798
PROPOSAL: #53798 (comment)
Tests
Categories :
Taxes :
Distance Rates :
Tags :
Multilevel Tags :
Prerequisites:
Report Fields :
Offline tests
Same as tests
QA Steps
Same as tests
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Screen.Recording.2024-12-12.at.00.45.35.mov
Android: mWeb Chrome
Screen.Recording.2024-12-12.at.00.51.20.mov
iOS: Native
Screen.Recording.2024-12-12.at.00.45.35.mov
iOS: mWeb Safari
Screen.Recording.2024-12-12.at.00.51.20.mov
MacOS: Chrome / Safari
Categories:
Screen.Recording.2024-12-12.at.00.52.19.mov
Taxes:
taxes.mov
Distance Rates:
distance.mov
Tags:
tags-single.mov
Multilevel Tags:
tags-mult.mov
Report Fields:
report-fields.mov
MacOS: Desktop
Screen.Recording.2024-12-10.at.00.04.15.mov