fixing return type and adding to test plugin

Expensify · Dec 23, 2024 · 5962cdc · 5962cdc
1 parent fb549a8
commit 5962cdc
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 2 deletions.
diff --git a/BedrockServer.cpp b/BedrockServer.cpp
@@ -1594,7 +1594,7 @@ void BedrockServer::unblockCommandPort(const string& reason) {
     }
 }
 
-virtual void isCommandPortClosed(const string& reason) {
+virtual bool isCommandPortClosed(const string& reason) {
     if (!strlen(reason)) {
         return _isCommandPortLikelyBlocked;
     }

diff --git a/sqlitecluster/SQLiteServer.h b/sqlitecluster/SQLiteServer.h
@@ -17,5 +17,5 @@ class SQLiteServer : public STCPManager {
     // You must block and unblock the command port with *identical strings*.
     virtual void blockCommandPort(const string& reason);
     virtual void unblockCommandPort(const string& reason);
-    virtual void isCommandPortClosed(const string& reason);
+    virtual bool isCommandPortClosed(const string& reason);
 };
diff --git a/test/tests/SQLiteNodeTest.cpp b/test/tests/SQLiteNodeTest.cpp
@@ -28,6 +28,7 @@ class TestServer : public SQLiteServer {
     virtual void notifyStateChangeToPlugins(SQLite& db, SQLiteNodeState newState) {}
     virtual void blockCommandPort(const string& reason) { };
     virtual void unblockCommandPort(const string& reason) { };
+    virtual bool isCommandPortClosed(const string& reason) { return false; };
 };
 
 struct SQLiteNodeTest : tpunit::TestFixture {