Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for using WARP software rasterizer with the D3D11 backend #178

Merged
merged 2 commits into from
Oct 1, 2023

Conversation

kg
Copy link
Contributor

@kg kg commented Oct 1, 2023

by setting FNA3D_D3D11_USE_WARP=1

WARP software rasterizer ships with Windows and is fast enough on multicore machines to be useful as a debugging tool (to rule out driver issues, etc) or even as a manual fallback if the user has a bad GPU.

See https://learn.microsoft.com/en-us/windows/win32/direct3darticles/directx-warp and https://learn.microsoft.com/en-us/windows/win32/direct3d11/overviews-direct3d-11-devices-create-warp

Copy link
Member

@flibitijibibo flibitijibibo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few changes to shrink the diffs via SDL_GetHintBoolean, otherwise fine!

src/FNA3D_Driver_D3D11.c Outdated Show resolved Hide resolved
src/FNA3D_Driver_D3D11.c Outdated Show resolved Hide resolved
src/FNA3D_Driver_D3D11.c Outdated Show resolved Hide resolved
@flibitijibibo flibitijibibo merged commit 71073a3 into FNA-XNA:master Oct 1, 2023
4 of 5 checks passed
@Popax21
Copy link

Popax21 commented Oct 12, 2023

The refactoring changes in 37ec1d9 seemed to have introduced a severe bug - see #179.

@kg
Copy link
Contributor Author

kg commented Oct 12, 2023

Good catch @Popax21 , I didn't notice it since I didn't do a fresh local build after applying the code review suggestions.

@flibitijibibo
Copy link
Member

Will merge the fix as soon as it's submitted!

@Popax21
Copy link

Popax21 commented Oct 12, 2023

Will merge the fix as soon as it's submitted!

Well, the fix is just swapping the options around for both ternaries. Since it's such a simple fix I was under the impression that going through a PR might be more effort from the overhead, however if it's easier for you I can quickly create one.

@flibitijibibo
Copy link
Member

Go for it, I'll be in the office in a bit so I can merge and then rebuild fnalibs as soon as I'm in!

@Popax21
Copy link

Popax21 commented Oct 12, 2023

Go for it, I'll be in the office in a bit so I can merge and then rebuild fnalibs as soon as I'm in!

Dang, seems like I missed the time window by just a bit .-. (context: commit fcfab15 just fixed this)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants