Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Vulkan renderer #215

Merged
merged 2 commits into from
Dec 23, 2024
Merged

Remove Vulkan renderer #215

merged 2 commits into from
Dec 23, 2024

Conversation

TheSpydog
Copy link
Member

Now that we have SDL_GPU, we can remove our old Vulkan renderer. And since it was the only backend that used FNA3D_Memory and FNA3D_CommandBuffer, we can delete those along with it!

Still need to test VisualC-GDK and Xcode, but the other build systems are happy with this change.

@flibitijibibo flibitijibibo marked this pull request as draft November 8, 2024 16:19
@flibitijibibo
Copy link
Member

Marked as a draft until #219 is done - this will be removed in 25.01 at the latest but if threading support gets done early we could probably do this a month early...

Copy link
Member

@flibitijibibo flibitijibibo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll probably want to readd the one GDK thing but other than that we're good to go on this.

@TheSpydog TheSpydog marked this pull request as ready for review December 23, 2024 20:10
@TheSpydog TheSpydog merged commit 2862845 into master Dec 23, 2024
28 checks passed
@TheSpydog TheSpydog deleted the rip-vulkan branch December 23, 2024 20:15
@thatcosmonaut
Copy link
Member

Good night, sweet prince, and flights of angels sing thee to thy rest.
🪦👼

@flibitijibibo
Copy link
Member

lol rip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants