This repository has been archived by the owner on Dec 19, 2024. It is now read-only.
Main bot code #29
Open
Main bot code #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Craftzman7
requested review from
doinkythederp,
Gavin-Niederman and
rezetta15
rezetta15
reviewed
Dec 13, 2024
| start() | ||
| } | ||
| return runEnd({ | ||
| val setpoint = magnitude * sin(timer.get() / 2.0) + center |
There was a problem hiding this comment.
WTF is this? Deserves a comment to explain how giving a timer value to a sine function is used for a set point.
rezetta15
reviewed
Dec 13, 2024
| rightMotor.setPosition(position.`in`(Rotations)) | ||
| } | ||
| inputs.reference = Rotations.of(leftMotor.closedLoopReference.value) | ||
| } |
There was a problem hiding this comment.
Given our history with getting funky encoder values we should be doing sanity checking here. Not only the encoder position but also the relative position and voltage.
Co-authored-by: doinkythederp <[email protected]>
Co-authored-by: doinkythederp <[email protected]>
Co-authored-by: doinkythederp <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.