This repository has been archived by the owner on Dec 11, 2024. It is now read-only.
feat(vision): use megatag2 for LL and working LL diagnostics #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rezetta15
approved these changes
Oct 8, 2024
|
This will be tested at the meeting today. |
|
The code for MegaTag 2 works but the Limelight localization settings are wrong and need to be corrected. |
rezetta15
reviewed
Oct 9, 2024
| init { | ||
| limelightAddrs.add("10.36.36.11") // TODO: Think of a better way to do this |
There was a problem hiding this comment.
Do we need the IP of the camera anywhere else?
rezetta15
reviewed
Oct 9, 2024
| Thread.sleep(2000) | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
Do we need to recheck isDamon? Can it be combined or could we just return if false?
There was a problem hiding this comment.
isDaemon is a named parameter to a function and isn't being checked by us - although we could combine these 2 threads into one single "diagnostics" thread
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: https://docs.limelightvision.io/docs/docs-limelight/pipeline-apriltag/apriltag-robot-localization-megatag2