Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix JTemplateTree bugs #490

Merged
merged 5 commits into from
Nov 12, 2023
Merged

Fix JTemplateTree bugs #490

merged 5 commits into from
Nov 12, 2023

Conversation

FWDekker
Copy link
Owner

Fixes #485:

  • Drag-and-drop behaviour has been added back in by no longer assuming that exchangeRows always takes consecutive rows. For ease of use (and more precision) the code relies on RefinedDropSupport, but unfortunately this means that the model is now again bound to the view, but luckily that is limited to two fields. These changes have been well-documented and well-tested.
  • The issues with using arrow keys seems to have been resolved by allowing the model to map view-based indices to model-based indices in a few select cases. This, too, is explained better in the code's docs than here.
  • Duplication issues were resolved by checking upon insertion of a node that this causes no conflicts with existing schemes, and automatically resolving these conflicts.

Mostly fixes #485, except for the reset causing UUID duplication.
@FWDekker FWDekker added the bug Something isn't working label Nov 10, 2023
@FWDekker FWDekker added this to the v3.0.0 milestone Nov 10, 2023
@FWDekker FWDekker self-assigned this Nov 10, 2023
Resolves the last bug noted in #485.
Copy link

codecov bot commented Nov 10, 2023

Codecov Report

Merging #490 (9a3338f) into main (dbdde6c) will increase coverage by 0.00%.
The diff coverage is 94.11%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #490   +/-   ##
=======================================
  Coverage   85.92%   85.92%           
=======================================
  Files          51       51           
  Lines        1897     1940   +43     
  Branches      321      333   +12     
=======================================
+ Hits         1630     1667   +37     
- Misses        209      213    +4     
- Partials       58       60    +2     

To more clearly indicate that this is a recursive, relatively expensive operation that should be stored in a local variable instead of blindly repeatedly invoking it.
@FWDekker FWDekker merged commit 64378e7 into main Nov 12, 2023
4 checks passed
@FWDekker FWDekker deleted the fix-template-tree branch November 12, 2023 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JTemplateTree bug round-up
1 participant