Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New error reporter #523

Merged
merged 3 commits into from
Jan 14, 2024
Merged

New error reporter #523

merged 3 commits into from
Jan 14, 2024

Conversation

FWDekker
Copy link
Owner

@FWDekker FWDekker commented Jan 14, 2024

Fixes #455.

The new error reporter is inspired by Patrick Scheibe's error reporter, though significant changes have been made:

  1. Rewritten in Kotlin
  2. Completely different class structure
  3. Fetches up-to-date token from repo
  4. Includes attachments
  5. Allows multiple stacktraces
  6. Ensures synchronization when multiple errors are reported simultaneously

Test coverage is, unfortunately, extremely poor because this is hard to test, and to be honest I don't really feel like adding entire mock structures everywhere to test code that is mostly quite obvious from reading it.

@FWDekker FWDekker added the feature New feature or request label Jan 14, 2024
@FWDekker FWDekker self-assigned this Jan 14, 2024
Copy link

codecov bot commented Jan 14, 2024

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (2274a0e) 85.50% compared to head (d206663) 85.50%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #523   +/-   ##
=======================================
  Coverage   85.50%   85.50%           
=======================================
  Files          51       51           
  Lines        2035     2035           
  Branches      343      343           
=======================================
  Hits         1740     1740           
  Misses        224      224           
  Partials       71       71           

@FWDekker FWDekker merged commit 97c8f66 into main Jan 14, 2024
8 checks passed
@FWDekker FWDekker deleted the new-error-reporter branch January 14, 2024 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error reporter: Create issue only if stacktrace fits
1 participant