Network addon session refactor #3394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
modmuss50
added
bug
liach
reviewed
Oct 29, 2023
...working-api-v1/src/main/java/net/fabricmc/fabric/impl/networking/GlobalReceiverRegistry.java
Outdated
Show resolved
Hide resolved
...etworking-api-v1/src/main/java/net/fabricmc/fabric/impl/networking/AbstractNetworkAddon.java
Outdated
Show resolved
Hide resolved
modmuss50
added
the
priority:high
modmuss50
added a commit
that referenced
this pull request
Nov 2, 2023
* refactor network addon session handling * Check payload size * Fix ClientLoginNetworkAddon does not handle unsuccessful query responses Closes #3384 * Adjust some logging. --------- Co-authored-by: deirn <[email protected]> (cherry picked from commit bff13c8)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Big thanks to @deirn for 98% of the changes in this PR, this is a follow on from #3377 to correctly handle the transition between config and play.
This PR also contains a fix for #3384 and now correctly validates the packet size in a few places where it wasnt previously. Testing still needs to be done, will likely release this in a beta.