Various mappings, renames, and fixes #3715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apple502j
approved these changes
Nov 2, 2023
YanisBft
approved these changes
Nov 2, 2023
BD103
added a commit
to BD103/TreeToppler
that referenced
this pull request
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's that time again, I went through some packages and mapped a few things, and fixed some issues I found along the way.
Maybe should be split up, but most of the classes are just one line changes so eh it's manageable I think
Only a few packages done, any further ones I do (if I do them) will be a separate PR
Notable renames include:
JigsawOrientation->Orientation: it's used by Crafters too now!CopperBulbBlockandOxidizableCopperBulbBlock->BulbBlockandOxidizableBulbBlock: more consistent with how other copper related block classes are named in Yarn, and feels less constricting on how mods could use themBambooSaplingBlock->BambooShootBlock: Matches its in-game name rather than its ID. It doesn't extend the sapling class anyway!Blocks#createBambooBlock->Blocks#createLogBlock: It's used by Cherry Logs too now! Plus the previous name could confuse as to if it made Bamboo blocks, or Bamboo Block blocks. It was the latter. It just makes a log with a custom sound group.Most other things are just mapping lambda params and a couple fields and method params.