-
Notifications
You must be signed in to change notification settings - Fork 768
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to support Gymnasium v1.0 #610
Update to support Gymnasium v1.0 #610
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
LGTM too, thanks Mark! |
Since this was merged, the upload to PyPi is now failing (e.g. for release 1.10) with
see https://github.com/Farama-Foundation/HighwayEnv/actions/runs/10442911768/job/28915719241 Do you have an idea where this |
The problem is that the release is using |
This PR works to update the project to Support Gymnasium v1.0
In part it adds testing using
check_env
for all the registered highway-env environments, which uncovered a couple of issues that are fixed (primarily in exit env and the multi-agent wrapper)As a result of removing the plugin system requiring that users import highway_env to register the environments, I have bumped the project version to 2.0.0, this might be unnecessary and we could use 1.10.0