Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Sonarcloud Coverage by not including Catch2 #164

Merged
merged 1 commit into from
Dec 25, 2024

Conversation

TrentHouliston
Copy link
Member

The coverage was calculated for the catch2 library since it's coming in as a FetchContent module. This changes how the coverage flags are applied so that only the NUClear library and the tests have coverage arcs on them.

@TrentHouliston TrentHouliston changed the title Fix Sonarcloud Coverage by not including catch2 Fix Sonarcloud Coverage by not including Catch2 Dec 25, 2024
@TrentHouliston TrentHouliston merged commit 46d9e04 into main Dec 25, 2024
13 of 14 checks passed
@TrentHouliston TrentHouliston deleted the houliston/fix-coverage-again branch December 25, 2024 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant