Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for canonical JSON output in Jackson 2.16 #3967
Support for canonical JSON output in Jackson 2.16 #3967
Changes from 2 commits
7b9cf6a
e5ebecb
b5b5fee
c89e22f
62882cc
978afd2
f2881df
26b881c
1690cf7
1e2cd6a
e83a68c
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's not going to be possible since with 3.0 especially there are be per-format sub-classes of
ObjectMapper
(2.x actually has these too, but with 3.0 it is more fundamentally so, to match particularTokenStreamFactory
with matchingObjectMapper
subtype).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmmm... I feel that the implementation of the builders as is leads to a lot of code duplication. Any ideas how to improve this?