This repository has been archived by the owner on Nov 19, 2018. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 21
Update AWS PHP SDK to v3 #8
Open
jaredcassidy
wants to merge
3
commits into
FineUploader:master
Choose a base branch
from
jaredcassidy:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change aws-sdk-php to version 3
akazakou
suggested changes
Jun 8, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need fix my comments for both files, because right now it doesn't work
return new S3Client([ | ||
'region' => $s3Region, | ||
'version' => '2006-03-01', | ||
'signature_version' => $s3Signature_version, |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
@@ -68,6 +72,10 @@ | |||
// and other POST requests (all requests are sent to the same endpoint in this example). | |||
// This condition is not needed if you don't require a callback on upload success. | |||
if (isset($_REQUEST["success"])) { | |||
//If Region is set in uploadSuccess params then override the default us-east-1 | |||
$s3Region = (isset($_REQUEST["region"]) ? $_REQUEST["region"] : 'us-east-1'); |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
// The following variables are used when validating the policy document | ||
// sent by the uploader. | ||
$expectedBucketName = $_ENV['S3_BUCKET_NAME']; | ||
$expectedHostName = $_ENV['S3_HOST_NAME']; // v4-only |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
return new S3Client([ | ||
'region' => $s3Region, | ||
'version' => '2006-03-01', | ||
'signature_version' => $s3Signature_version, |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.