Develop #43
Open
Develop #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Preparing for 2.0 release
Signed-off-by: Aurélien Bompard <[email protected]>
Add missing import
…project.toml and use tox
…) and don't check junk env stuff
…bc object generation test reliance, pass in app data rather than rely on global or local context scoping.
…n my_conv based on the msg_style
…declares the docstring for the legacy implementation as well as the py2 workaround for typehinting
… branches in PamAuthenticate
Fixes FirefighterBlu3#31 by restoring the boolean return value and redeclares the do…
…cking-libpam Develop mocking libpam
…e-version-for-2.0.2 update the version to 2.0.2
exclude .venv folder
|
The action issue: Is it still pep8 CONFORM to support py2? I have some doubts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I recognized the out-of-sync branches develop/master
I've updated the .gitignore to fullfill my needs for virtual environemnts.
I sticked with the changes for py2 support but would really say, this should be dropped completely in future releases (3.0.0?).
I did not changed yet to another build system. I prefer working with poetry, because it provides local development in a logical behavior.
Just one other point: the tox tests in this environment, doesn't finish and I am not very familiar with tox.